Page MenuHomePhorge

inka (Inka Sokołowska)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2022, 9:18 AM (177 w, 2 d)

Recent Activity

Oct 21 2024

inka closed D13750: [lib] Handle identity timeout when fetching device lists.
Oct 21 2024, 1:42 PM
inka closed D13741: [lib] Delete users for whom identity didnt return a device list for a long time.
Oct 21 2024, 1:42 PM
inka committed rCOMMda9fc92ba039: [lib] Delete users for whom identity didnt return a device list for a long time.
Oct 21 2024, 1:42 PM
inka committed rCOMM601124623861: [lib] Handle identity timeout when fetching device lists.
Oct 21 2024, 1:42 PM
inka closed D13740: [lib] Reduce removePeerUsersActionType in thread reducer.
Oct 21 2024, 1:42 PM
inka closed D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.
Oct 21 2024, 1:42 PM
inka committed rCOMM3522e8e1d74d: [lib] Reduce removePeerUsersActionType in thread reducer.
Oct 21 2024, 1:42 PM
inka committed rCOMMef097d633879: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.
Oct 21 2024, 1:42 PM
inka closed D13728: [lib] Mark missing users when fetching device lists.
Oct 21 2024, 1:42 PM
inka closed D13727: [lib] Reduce users missing from identity.
Oct 21 2024, 1:42 PM
inka committed rCOMM2f8d10eabd43: [lib] Reduce users missing from identity.
Oct 21 2024, 1:42 PM
inka committed rCOMMe03089ba3f24: [lib] Mark missing users when fetching device lists.
Oct 21 2024, 1:42 PM
inka closed D13726: [lib] Add accountMissingStatus.
Oct 21 2024, 1:42 PM
inka committed rCOMM2c21ca6e4f8b: [lib] Add accountMissingStatus.
Oct 21 2024, 1:42 PM
inka added inline comments to D13750: [lib] Handle identity timeout when fetching device lists.
Oct 21 2024, 1:07 PM
inka updated the diff for D13741: [lib] Delete users for whom identity didnt return a device list for a long time.

Rebase, address review

Oct 21 2024, 12:25 PM
inka added inline comments to D13740: [lib] Reduce removePeerUsersActionType in thread reducer.
Oct 21 2024, 11:25 AM
inka updated the diff for D13740: [lib] Reduce removePeerUsersActionType in thread reducer.

Update payload type

Oct 21 2024, 11:25 AM

Oct 18 2024

inka requested review of D13750: [lib] Handle identity timeout when fetching device lists.
Oct 18 2024, 10:54 AM
inka updated the diff for D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.

Remove changes to useUsersSupportThickThreads

Oct 18 2024, 9:20 AM
inka added inline comments to D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.
Oct 18 2024, 9:12 AM

Oct 17 2024

inka updated the diff for D13741: [lib] Delete users for whom identity didnt return a device list for a long time.

Rebase

Oct 17 2024, 1:28 PM
inka updated the diff for D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.

Rebase

Oct 17 2024, 1:28 PM
inka updated the diff for D13728: [lib] Mark missing users when fetching device lists.

Device list can be empty for a registered user if they log out of all devices

Oct 17 2024, 1:24 PM
inka added a comment to D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.

Initially I modified useGetAndUpdateDeviceListsForUsers, but I realised that it is used in many places. Some of those places seem like we don't want to use this mechanism.

  • In UserInfosHandler we want to request all missing device lists as the app starts. There is a special mechanism there to make sure we request them exactly once.
  • In SecondaryDeviceQRCodeScanner we request current users device list, so it can never be empty as far as I understand.
  • In usePeerToPeerMessageHandler we request the device list when we receive a DEVICE_LIST_UPDATED or IDENTITY_DEVICE_LIST_UPDATED. I feel like we really want to request the device list in this case, and ignore the timeout.
Oct 17 2024, 1:05 PM
inka requested review of D13741: [lib] Delete users for whom identity didnt return a device list for a long time.
Oct 17 2024, 11:40 AM
inka requested review of D13740: [lib] Reduce removePeerUsersActionType in thread reducer.
Oct 17 2024, 11:29 AM

Oct 16 2024

inka requested review of D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.
Oct 16 2024, 4:02 PM
inka requested review of D13728: [lib] Mark missing users when fetching device lists.
Oct 16 2024, 3:52 PM
inka requested review of D13727: [lib] Reduce users missing from identity.
Oct 16 2024, 3:46 PM
inka requested review of D13726: [lib] Add accountMissingStatus.
Oct 16 2024, 3:45 PM

Oct 14 2024

inka closed D13697: [native] Fix NUX Android problem.
Oct 14 2024, 2:24 PM
inka committed rCOMMe43c6b922c25: [native] Fix NUX Android problem.
Oct 14 2024, 2:24 PM
inka added inline comments to D13697: [native] Fix NUX Android problem.
Oct 14 2024, 11:46 AM
inka updated the diff for D13697: [native] Fix NUX Android problem.

Move callbacks out of components

Oct 14 2024, 11:46 AM
inka added inline comments to D13697: [native] Fix NUX Android problem.
Oct 14 2024, 9:20 AM
inka updated the diff for D13697: [native] Fix NUX Android problem.

Bind measure

Oct 14 2024, 9:19 AM
inka updated the diff for D13697: [native] Fix NUX Android problem.

Address review. Going to try biding the methods now

Oct 14 2024, 8:58 AM

Oct 11 2024

inka requested review of D13697: [native] Fix NUX Android problem.
Oct 11 2024, 10:11 AM

Oct 10 2024

inka accepted D13632: [native] Avoid updating relationships before the previous call finished.
Oct 10 2024, 11:51 AM
inka accepted D13614: [lib] Fix leaving thread logic.

Please address Ashoat's comments before landing

Oct 10 2024, 11:45 AM

Oct 8 2024

inka added inline comments to D13614: [lib] Fix leaving thread logic.
Oct 8 2024, 8:44 AM

Oct 4 2024

inka accepted D13590: [keyserver] Show the most recent thread when opening the web app without providing a thread ID.
Oct 4 2024, 10:27 AM
inka closed D13585: [native] Fix styling in animation code.
Oct 4 2024, 10:25 AM
inka committed rCOMMee7e376f90ec: [native] Fix styling in animation code.
Oct 4 2024, 10:25 AM
inka added a comment to D13585: [native] Fix styling in animation code.

To verify that this formatting is correct we could consider deleting ignore and worker directives, auto-formatting the code, and reintroducing the directives.

Oct 4 2024, 10:12 AM

Oct 3 2024

inka requested review of D13585: [native] Fix styling in animation code.
Oct 3 2024, 10:22 AM

Oct 1 2024

inka requested review of D13554: [lib] Fix messages disappearing from thick sidebars.
Oct 1 2024, 12:27 PM
inka accepted D13536: [lib] Factor out useOldestPrivateThreadInfo.
Oct 1 2024, 11:33 AM
inka accepted D13535: [keyserver] Stop creating GENESIS_PRIVATE thread on account creation.
Oct 1 2024, 11:31 AM
inka accepted D13534: [lib] Simplify useExistingThreadInfoFinder.
Oct 1 2024, 11:28 AM
inka added a comment to D13533: [lib] Update useUserProfileThreadInfo to consider thick threads.

Why do we expect to have multiple private chats, or multiple personal chats with one user? It's it impossible?

Oct 1 2024, 11:06 AM
inka accepted D13532: [lib] Fix thread search order for thick threads.
Oct 1 2024, 9:56 AM
inka accepted D13531: [lib] Narrow getThreadTypeParentRequirement param to ThinThreadType.
Oct 1 2024, 9:55 AM
inka closed D13520: [native] Fix crash in NUX.
Oct 1 2024, 9:48 AM
inka committed rCOMMd17d71bec3ff: [native] Fix crash in NUX.
Oct 1 2024, 9:48 AM

Sep 30 2024

inka accepted D13423: [lib] Enable thick thread creation for all the users.
Sep 30 2024, 3:47 PM
inka requested review of D13520: [native] Fix crash in NUX.
Sep 30 2024, 1:06 PM

Sep 13 2024

inka added inline comments to D13335: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.
Sep 13 2024, 4:02 PM
inka closed D13336: [lib] Update useAncestorThreads to consider thick threads.
Sep 13 2024, 3:59 PM
inka committed rCOMM1a48c411011f: [lib] Update useAncestorThreads to consider thick threads.
Sep 13 2024, 3:59 PM
inka closed D13320: [web][native] Update UI to not display GENESIS over thick threads.
Sep 13 2024, 3:59 PM
inka committed rCOMM529b78e6344c: [web][native] Update UI to not display GENESIS over thick threads.
Sep 13 2024, 3:59 PM
inka closed D13335: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.
Sep 13 2024, 3:59 PM
inka committed rCOMMaed77d4733bd: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.
Sep 13 2024, 3:59 PM
inka closed D13333: [lib] update threadLabel to handle thick threads.
Sep 13 2024, 3:59 PM
inka committed rCOMM48db54e22644: [lib] update threadLabel to handle thick threads.
Sep 13 2024, 3:59 PM
inka closed D13275: Update search header in chat creation on native not to show GENESIS for thick threads.
Sep 13 2024, 3:59 PM
inka committed rCOMM1d9f1a465c67: Update search header in chat creation on native not to show GENESIS for thick… (authored by marcin).
Sep 13 2024, 3:59 PM
inka updated the diff for D13336: [lib] Update useAncestorThreads to consider thick threads.

Address review

Sep 13 2024, 3:34 PM
inka requested review of D13336: [lib] Update useAncestorThreads to consider thick threads.
Sep 13 2024, 2:41 PM
inka requested review of D13335: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.
Sep 13 2024, 2:19 PM
inka updated the diff for D13333: [lib] update threadLabel to handle thick threads.

Simplify

Sep 13 2024, 1:14 PM
inka requested review of D13333: [lib] update threadLabel to handle thick threads.
Sep 13 2024, 1:02 PM
inka updated the diff for D13320: [web][native] Update UI to not display GENESIS over thick threads.

Remove unecessary memos

Sep 13 2024, 12:49 PM
inka updated the test plan for D13275: Update search header in chat creation on native not to show GENESIS for thick threads.
Sep 13 2024, 12:30 PM
inka updated the diff for D13275: Update search header in chat creation on native not to show GENESIS for thick threads.

Rebase, fix determining whether thread is thick

Sep 13 2024, 12:28 PM
inka requested review of D13320: [web][native] Update UI to not display GENESIS over thick threads.
Sep 13 2024, 10:28 AM

Sep 12 2024

inka closed D13267: [web][native] Show relationship prompt in thick PERSONAL threads.
Sep 12 2024, 3:04 PM
inka committed rCOMMf5bfcaa5f197: [web][native] Show relationship prompt in thick PERSONAL threads.
Sep 12 2024, 3:04 PM
inka closed D13266: [lib] Update existingThreadInfoFinder to handle thick threads.
Sep 12 2024, 3:04 PM
inka committed rCOMM937dd440cde6: [lib] Update existingThreadInfoFinder to handle thick threads.
Sep 12 2024, 3:04 PM
inka closed D13259: [lib] Fix sendnig create_sidebar to peers.
Sep 12 2024, 3:04 PM
inka committed rCOMM4a9159903769: [lib] Fix sendnig create_sidebar to peers.
Sep 12 2024, 3:04 PM
inka closed D13258: [lib][native] Review usingOlmViaTunnelbrokerForDMs and pendingThreadType.
Sep 12 2024, 3:04 PM
inka closed D13253: [lib][web][native] Update createPendingThread usages.
Sep 12 2024, 3:04 PM
inka committed rCOMM6143b817503c: [lib][native] Review usingOlmViaTunnelbrokerForDMs and pendingThreadType.
Sep 12 2024, 3:04 PM
inka committed rCOMM4f1fb05ccf70: [lib][web][native] Update createPendingThread usages.
Sep 12 2024, 3:04 PM
inka closed D13244: [lib][web][native] Update createRealThreadFromPendingThread to handle thick thread creation.
Sep 12 2024, 3:04 PM
inka closed D13243: [lib] Add useNewThickThread.
Sep 12 2024, 3:04 PM
inka committed rCOMM9428742124b0: [lib][web][native] Update createRealThreadFromPendingThread to handle thick….
Sep 12 2024, 3:04 PM
inka committed rCOMM7143343df124: [lib] Add useNewThickThread.
Sep 12 2024, 3:04 PM
inka closed D13306: [lib] Fix read only in thread-types.
Sep 12 2024, 3:04 PM
inka committed rCOMM73571573414d: [lib] Fix read only in thread-types.
Sep 12 2024, 3:04 PM
inka abandoned D13288: [lib] Fix useProcessAndSendDMOperation.

Without this diff, problem from ENG-9187 is not resolved. However

  1. This diff introduces a different problem - if the component which calls this hook is unmounted before the effect is run, the operation is lost
  2. We are changing the approach to generating DM ops (D13290), and @kamil will be landing code rendering this diff unnecessary - most likely tomorrow
Sep 12 2024, 2:54 PM
inka planned changes to D13275: Update search header in chat creation on native not to show GENESIS for thick threads.

@marcin changed a different place than I had in mind, but this made me realise that we call threadTypeIsThick check on a result of pendingThreadType. So the outcome is determined by the flag we use in this pendingThreadType. We should create a proper childThreadType depending on whether we want thick or thin and then use it in ParentThreadHeader

Sep 12 2024, 2:19 PM
inka added reviewers for D13275: Update search header in chat creation on native not to show GENESIS for thick threads: tomek, kamil.
Sep 12 2024, 2:15 PM
inka updated the diff for D13266: [lib] Update existingThreadInfoFinder to handle thick threads.

Rebase

Sep 12 2024, 2:13 PM
inka updated the diff for D13259: [lib] Fix sendnig create_sidebar to peers.

Address review

Sep 12 2024, 2:13 PM
inka updated the diff for D13258: [lib][native] Review usingOlmViaTunnelbrokerForDMs and pendingThreadType.

Address review

Sep 12 2024, 2:07 PM