To confirm the deletion of a keyserver, I will need a very similar modal to the delete role modal. Rather than copying and pasting, I introduced a ConfirmationAlert component that can be used in both instances.
Depends on D10080
Paths
| Differential D10081 Authored by ginsu on Nov 28 2023, 8:32 PM.
Details Summary To confirm the deletion of a keyserver, I will need a very similar modal to the delete role modal. Rather than copying and pasting, I introduced a ConfirmationAlert component that can be used in both instances. Depends on D10080 Test Plan Confirmed that the delete role modal looked and behaved as before
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptNov 28 2023, 8:32 PM2023-11-28 20:32:47 (UTC-8) ginsu edited the summary of this revision. (Show Details)Nov 28 2023, 8:53 PM2023-11-28 20:53:20 (UTC-8) Harbormaster completed remote builds in B24589: Diff 33968.Nov 28 2023, 9:08 PM2023-11-28 21:08:11 (UTC-8) Comment Actions Thanks for doing this! Could you share a screenshot for what the delete roles modal looks like now please? This revision is now accepted and ready to land.Nov 29 2023, 3:59 AM2023-11-29 03:59:16 (UTC-8) ginsu attached a referenced file: F902252: Screenshot 2023-11-30 at 12.59.25 AM.png. (Show Details)Nov 29 2023, 10:00 PM2023-11-29 22:00:29 (UTC-8) Harbormaster completed remote builds in B24620: Diff 34021.Nov 29 2023, 10:17 PM2023-11-29 22:17:40 (UTC-8) Closed by commit rCOMMd19f5c7d992a: [web] introduce confirmation alert component (authored by ginsu). · Explain WhyNov 29 2023, 10:42 PM2023-11-29 22:42:12 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 34024 web/modals/confirmation-alert.css
web/modals/confirmation-alert.react.js
web/roles/delete-role-modal.css
web/roles/delete-role-modal.react.js
|