Details

Reviewers

inka
michal
rohan

Commits

rCOMMf68ce52a93a2: [lib/native] lift set custom server action type into lib

Summary

At the moment, the customServer redux field lives only in native. Since we want to use this state in web as well, we will need to lift the redux logic into lib. This diff handles lifting the set custom server action type into lib, and a subsequent diff will handle lifting the redux state into lib.

Depends on D10089

Test Plan

flow and confirmed that the custom server url on native still works as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 29 2023, 12:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 29 2023, 12:41 AM

ginsu retitled this revision from [lib/native] lift set custom server url action type into lib to [lib/native] lift set custom server action type into lib.Nov 29 2023, 12:43 AM

update

ginsu edited the summary of this revision. (Show Details)Nov 29 2023, 12:50 AM

ginsu added reviewers: inka, michal, rohan.

ginsu added a parent revision: D10089: [web] introduce on click remove keyserver functionality.

ginsu edited the summary of this revision. (Show Details)Nov 29 2023, 12:59 AM

Harbormaster completed remote builds in B24601: Diff 33980.Nov 29 2023, 1:00 AM

ginsu added a child revision: D10092: [lib/native/web] lift customServer redux state into lib.Nov 29 2023, 1:10 AM

Harbormaster completed remote builds in B24603: Diff 33982.Nov 29 2023, 1:25 AM

ginsu requested review of this revision.Nov 29 2023, 1:25 AM

rohan accepted this revision.Nov 29 2023, 4:07 AM

This revision is now accepted and ready to land.Nov 29 2023, 4:07 AM

rebase before landing