Page MenuHomePhabricator
Differential D10092

[lib/native/web] lift customServer redux state into lib
ClosedPublic
Actions

Authored by ginsu on Nov 29 2023, 12:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 4:05 PM
Unknown Object (File)
Thu, Dec 12, 1:05 PM
Unknown Object (File)
Nov 25 2024, 10:46 PM
Unknown Object (File)
Nov 25 2024, 10:35 PM
Unknown Object (File)
Nov 25 2024, 8:17 PM
Unknown Object (File)
Nov 12 2024, 11:54 AM
Unknown Object (File)
Nov 8 2024, 6:09 PM
Unknown Object (File)
Oct 30 2024, 7:52 PM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
michal
rohan
Commits
rCOMM7797b12e0e16: [lib/native/web] lift customServer redux state into lib
Summary

At the moment, the customServer redux field lives only in native. Since we want to use this state in web as well, we will need to lift the redux logic into lib. This diff handles lifting the redux state into lib

Depends on D10090

Test Plan

flow and confirmed that the custom server on native works as expected

Here is a demo video also showing that the custom server field also works on web too

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 29 2023, 12:55 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 29 2023, 12:55 AM
ginsu added reviewers: inka, michal, rohan.Nov 29 2023, 1:02 AM
ginsu edited the summary of this revision. (Show Details)Nov 29 2023, 1:10 AM
ginsu added a parent revision: D10090: [lib/native] lift set custom server action type into lib.
ginsu added a child revision: D10093: [web] save the recently deleted server url to customServer redux state.Nov 29 2023, 1:18 AM
Harbormaster completed remote builds in B24604: Diff 33983.Nov 29 2023, 1:20 AM
ginsu requested review of this revision.Nov 29 2023, 1:20 AM
rohan accepted this revision.Nov 29 2023, 4:09 AM

Looks good to me - just would prefer if someone else could take a look though regarding the redux setup

This revision is now accepted and ready to land.Nov 29 2023, 4:09 AM
rohan resigned from this revision.Nov 29 2023, 4:09 AM
This revision now requires review to proceed.Nov 29 2023, 4:09 AM
inka accepted this revision.Nov 30 2023, 1:45 AM

Can you also check if calling setCustomServerActionType on web sets the value in the store?

This revision is now accepted and ready to land.Nov 30 2023, 1:45 AM
ginsu edited the test plan for this revision. (Show Details)Dec 4 2023, 10:51 PM
ginsu attached a referenced file: F911854: Screen Recording 2023-12-05 at 1.50.05 AM.mov. (Show Details)

Can you also check if calling setCustomServerActionType on web sets the value in the store?

Amended the test plan to show a demo of this

ginsu updated this revision to Diff 34252.Dec 4 2023, 10:54 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Dec 4 2023, 11:02 PM
Closed by commit rCOMM7797b12e0e16: [lib/native/web] lift customServer redux state into lib (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7797b12e0e16: [lib/native/web] lift customServer redux state into lib.
Harbormaster failed remote builds in B24787: Diff 34252!Dec 4 2023, 11:43 PM

Revision Contents
Changeset List

PathSize
lib/
reducers/
15 lines
2 lines
types/
1 line
native/
redux/
8 lines
web/
redux/
1 line
1 line
1 line

Diff 34258

View Options

lib/reducers/custom-server-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/persist.js

Loading...
View Options

web/redux/redux-setup.js

Loading...