[web] add keyserver url validation logic and error handling to the add keyserver modal
ClosedPublic
Actions

Authored by ginsu on Dec 4 2023, 6:44 AM.

Details

Reviewers

inka
michal
rohan

Commits

rCOMMc9a676d83f82: [web] add keyserver url validation logic and error handling to the add…

Summary

This diff adds keyserver url validation logic to the onClickAddKeyserver callback in the add keyserver modal. We also now display an error message if for any reason the keyserver url inputed by the user is not valid

Linear task: https://linear.app/comm/issue/ENG-4726/dispatch-add-keyserver-redux-action-when-onpress-save-button-is

Depends on D10094

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 4 2023, 6:44 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 4 2023, 6:44 AM

ginsu edited the summary of this revision. (Show Details)Dec 4 2023, 6:48 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, michal, rohan.

ginsu added a parent revision: D10094: [web] implement onClickAddKeyserver callback.

ginsu attached a referenced file: F909640: Screen Recording 2023-12-04 at 9.39.09 AM.mov. (Show Details)

ginsu added inline comments.Dec 4 2023, 6:59 AM

web/redux/action-types.js
53–55 ↗	(On Diff #34184)	As per @inka's message to the Comm Dev team a few days ago about using `ashoatKeyserverID`, here is a linear task to eventually revert this check when we have more extensive checks to add a keyserver to the keyserver store https://linear.app/comm/issue/ENG-6008/revert-ashoatkeyserverid-check-in-getinitialreduxstate