Page MenuHomePhabricator

[lib/native/web] lift customServer redux state into lib
ClosedPublic

Authored by ginsu on Nov 29 2023, 12:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 7:52 PM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:52 AM
Unknown Object (File)
Oct 2 2024, 1:51 AM
Unknown Object (File)
Oct 2 2024, 1:51 AM
Unknown Object (File)
Sep 27 2024, 3:57 PM
Unknown Object (File)
Sep 25 2024, 9:34 AM
Subscribers

Details

Summary

At the moment, the customServer redux field lives only in native. Since we want to use this state in web as well, we will need to lift the redux logic into lib. This diff handles lifting the redux state into lib

Depends on D10090

Test Plan

flow and confirmed that the custom server on native works as expected

Here is a demo video also showing that the custom server field also works on web too

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Nov 29 2023, 1:20 AM

Looks good to me - just would prefer if someone else could take a look though regarding the redux setup

This revision is now accepted and ready to land.Nov 29 2023, 4:09 AM
This revision now requires review to proceed.Nov 29 2023, 4:09 AM

Can you also check if calling setCustomServerActionType on web sets the value in the store?

This revision is now accepted and ready to land.Nov 30 2023, 1:45 AM

Can you also check if calling setCustomServerActionType on web sets the value in the store?

Amended the test plan to show a demo of this

ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Dec 4 2023, 11:02 PM
This revision was automatically updated to reflect the committed changes.