Page MenuHomePhabricator
Differential D10772

[lib] refactor setting device token in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:41 AM.
Tags
None
Referenced Files
F4948778: D10772.id36380.diff
Thu, Mar 20, 12:03 AM
Unknown Object (File)
Tue, Mar 18, 9:11 PM
Unknown Object (File)
Tue, Mar 18, 7:32 AM
Unknown Object (File)
Thu, Mar 13, 10:54 PM
Unknown Object (File)
Fri, Mar 7, 8:34 AM
Unknown Object (File)
Mon, Mar 3, 7:56 PM
Unknown Object (File)
Fri, Feb 21, 8:35 AM
Unknown Object (File)
Fri, Feb 21, 8:35 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMMf5152a85ec1a: [lib] refactor setting device token in `keyserver-reducer` to ops
Summary

Convert logic to ops approach.

Depends on D10771

Test Plan

Refresh web app (it cause dispatching SET_DEVICE_TOKEN_SUCCESS ) and make sure state is properly set

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 3:41 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:41 AM
kamil added a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 22 2024, 3:42 AM
Harbormaster failed remote builds in B26000: Diff 35932!Jan 22 2024, 3:56 AM
kamil updated this revision to Diff 35947.Jan 22 2024, 4:26 AM

rebase

Harbormaster completed remote builds in B26014: Diff 35947.Jan 22 2024, 4:55 AM
ashoat added a comment.Jan 23 2024, 8:44 AM

Is there a reason this diff is a draft? (Maybe test plan)

kamil published this revision for review.Jan 27 2024, 9:39 AM
kamil edited the test plan for this revision. (Show Details)
In D10772#311124, @ashoat wrote:

Is there a reason this diff is a draft? (Maybe test plan)

yes, I wanted to check with @inka what is the best way to test it before publishing

inka accepted this revision.Jan 30 2024, 1:48 AM
This revision is now accepted and ready to land.Jan 30 2024, 1:48 AM
kamil updated this revision to Diff 36380.Jan 31 2024, 5:23 AM

rebase

Harbormaster completed remote builds in B26327: Diff 36380.Jan 31 2024, 5:42 AM
kamil added a child revision: D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops.Jan 31 2024, 5:46 AM
kamil removed a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 31 2024, 5:47 AM
kamil added a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 31 2024, 7:27 AM
kamil removed a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 31 2024, 7:29 AM
Closed by commit rCOMMf5152a85ec1a: [lib] refactor setting device token in `keyserver-reducer` to ops (authored by kamil). · Explain WhyJan 31 2024, 8:23 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf5152a85ec1a: [lib] refactor setting device token in `keyserver-reducer` to ops.

Revision Contents
Changeset List

PathSize
lib/
reducers/
20 lines

Diff 35947

View Options

lib/reducers/keyserver-reducer.js

Loading...