Paths

Table of Contentst

Differential D10772

[lib] refactor setting device token in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 11:41 AM.

Details

Reviewers

inka

Commits

rCOMMf5152a85ec1a: [lib] refactor setting device token in `keyserver-reducer` to ops

Summary

Convert logic to ops approach.

Depends on D10771

Test Plan

Refresh web app (it cause dispatching SET_DEVICE_TOKEN_SUCCESS ) and make sure state is properly set

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 22 2024, 11:41 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 11:41 AM

kamil added a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 22 2024, 11:42 AM

Harbormaster failed remote builds in B26000: Diff 35932!Jan 22 2024, 11:56 AM

rebase

Harbormaster completed remote builds in B26014: Diff 35947.Jan 22 2024, 12:55 PM

Is there a reason this diff is a draft? (Maybe test plan)

In D10772#311124, @ashoat wrote:

Is there a reason this diff is a draft? (Maybe test plan)

yes, I wanted to check with @inka what is the best way to test it before publishing

inka accepted this revision.Jan 30 2024, 9:48 AM

This revision is now accepted and ready to land.Jan 30 2024, 9:48 AM

rebase

Harbormaster completed remote builds in B26327: Diff 36380.Jan 31 2024, 1:42 PM

kamil added a child revision: D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops.Jan 31 2024, 1:46 PM

kamil removed a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 31 2024, 1:47 PM

kamil added a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 31 2024, 3:27 PM

kamil removed a child revision: D10773: [lib] refactor `reduceKeyserverStore` to return ops.Jan 31 2024, 3:29 PM

Closed by commit rCOMMf5152a85ec1a: [lib] refactor setting device token in `keyserver-reducer` to ops. · Explain WhyJan 31 2024, 4:23 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf5152a85ec1a: [lib] refactor setting device token in `keyserver-reducer` to ops.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

20 lines

Diff 36400

View Options

lib/reducers/keyserver-reducer.js

[lib] refactor setting device token in `keyserver-reducer` to opsClosedPublicActions