Prepare a request and call keyserver auth from a handler.
Depends on D10813
Details
Details
- Reviewers
varun inka kamil - Commits
- rCOMM61b020d624e3: [lib] Call keyserver auth
Check if the endpoint is called with provided data.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/components/keyserver-connection-handler.js | ||
|---|---|---|
| 135–145 ↗ | (On Diff #36132) | The logic of when to call this effect will be updated later in the stack |
| lib/components/keyserver-connection-handler.js | ||
|---|---|---|
| 60 ↗ | (On Diff #36132) | We probably should modify this logic when we perform a recovery |
| lib/components/keyserver-connection-handler.js | ||
|---|---|---|
| 45–49 ↗ | (On Diff #36161) | This logic is a bit confusing. I guess the reason we decided to store a separate deviceToken per keyserver is because we want to know if we've shared our deviceToken to that keyserver yet, not because we expect to have a different deviceToken per keyserver. It would probably make more sense if we have a deviceTokenHasBeenUploaded: boolean in KeyserverInfo, and a deviceToken field at the top level of Redux. But we'll likely end up removing deviceTokens from keyservers soon anyways... |
| lib/components/keyserver-connection-handler.js | ||
|---|---|---|
| 45–49 ↗ | (On Diff #36161) |
Agree. But moving the token to Tunnelbroker will simplify it even more. For now, I don't think it is worth fixing now. |