[lib] Create a selector that checks if a user is logged in to a keyserver
ClosedPublic
Actions

Authored by tomek on Jan 26 2024, 3:22 AM.

Details

Reviewers

varun
inka
kamil

Commits

rCOMMe7ae43ad692f: [lib] Create a selector that checks if a user is logged in to a keyserver

Summary

Check if user is logged in and if the cookie exists and isn't anonymous.

Depends on D10814

Test Plan

Call a selector for keyserver with ashoatKeyserverID and check if it returns true. Add a new keyserver to the store and check if the selector returns false for it.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jan 26 2024, 3:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2024, 3:22 AM

tomek requested review of this revision.Jan 26 2024, 5:01 AM

tomek added a child revision: D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.

Delete unnecessary check - a dependency on dataLoaded flag makes this logic invalid

inka added inline comments.Jan 26 2024, 5:44 AM

lib/selectors/user-selectors.js
175–177 ↗	(On Diff #36150)	In the next diff you use this selector, and if it returns false you retry login. But `isLoggedIn` returns false if `dataLoaded` is false. `dataLoaded` is only set to true once we connect to Ashoat's keyserver. So if the client manages to login to some other keyserver, before they log in to Ashoat's keyserver, this selector will nevertheless return false, and the handler will retry login

I see you fixed this as I was writing the comment

This revision is now accepted and ready to land.Jan 26 2024, 5:51 AM

Harbormaster completed remote builds in B26175: Diff 36157.Jan 26 2024, 6:03 AM

Closed by commit rCOMMe7ae43ad692f: [lib] Create a selector that checks if a user is logged in to a keyserver (authored by tomek). · Explain WhyJan 29 2024, 3:44 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe7ae43ad692f: [lib] Create a selector that checks if a user is logged in to a keyserver.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

user-selectors.js

10 lines

Diff 36157

View Options

lib/selectors/user-selectors.js

Show All 13 Lines
import androidx.core.app.NotificationCompat;		import androidx.core.app.NotificationCompat;
import androidx.lifecycle.Lifecycle;		import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.ProcessLifecycleOwner;		import androidx.lifecycle.ProcessLifecycleOwner;
import androidx.localbroadcastmanager.content.LocalBroadcastManager;		import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import app.comm.android.ExpoUtils;		import app.comm.android.ExpoUtils;
import app.comm.android.MainActivity;		import app.comm.android.MainActivity;
import app.comm.android.R;		import app.comm.android.R;
import app.comm.android.aescrypto.AESCryptoModuleCompat;		import app.comm.android.aescrypto.AESCryptoModuleCompat;
import app.comm.android.commservices.CommAndroidBlobClient;		import app.comm.android.commservices.CommAndroidServicesClient;
import app.comm.android.fbjni.CommMMKV;		import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore;		import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.GlobalDBSingleton;		import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.fbjni.MessageOperationsUtilities;		import app.comm.android.fbjni.MessageOperationsUtilities;
import app.comm.android.fbjni.NetworkModule;		import app.comm.android.fbjni.NetworkModule;
import app.comm.android.fbjni.NotificationsCryptoModule;		import app.comm.android.fbjni.NotificationsCryptoModule;
import app.comm.android.fbjni.StaffUtils;		import app.comm.android.fbjni.StaffUtils;
import app.comm.android.fbjni.ThreadOperations;		import app.comm.android.fbjni.ThreadOperations;
Show All 33 Lines	public class CommNotificationsHandler extends FirebaseMessagingService {
// Those and future MMKV-related constants should match		// Those and future MMKV-related constants should match
// similar constants in NotificationService.mm		// similar constants in NotificationService.mm
private static final String MMKV_KEY_SEPARATOR = ".";		private static final String MMKV_KEY_SEPARATOR = ".";
private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";		private static final String MMKV_KEYSERVER_PREFIX = "KEYSERVER";
private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";		private static final String MMKV_UNREAD_COUNT_SUFFIX = "UNREAD_COUNT";
private Bitmap displayableNotificationLargeIcon;		private Bitmap displayableNotificationLargeIcon;
private NotificationManager notificationManager;		private NotificationManager notificationManager;
private LocalBroadcastManager localBroadcastManager;		private LocalBroadcastManager localBroadcastManager;
private CommAndroidBlobClient blobClient;		private CommAndroidServicesClient servicesClient;
private AESCryptoModuleCompat aesCryptoModule;		private AESCryptoModuleCompat aesCryptoModule;

public static final String RESCIND_KEY = "rescind";		public static final String RESCIND_KEY = "rescind";
public static final String RESCIND_ID_KEY = "rescindID";		public static final String RESCIND_ID_KEY = "rescindID";
public static final String TITLE_KEY = "title";		public static final String TITLE_KEY = "title";
public static final String PREFIX_KEY = "prefix";		public static final String PREFIX_KEY = "prefix";
public static final String BODY_KEY = "body";		public static final String BODY_KEY = "body";
public static final String MESSAGE_INFOS_KEY = "messageInfos";		public static final String MESSAGE_INFOS_KEY = "messageInfos";
public static final String THREAD_ID_KEY = "threadID";		public static final String THREAD_ID_KEY = "threadID";

public static final String TOKEN_EVENT = "TOKEN_EVENT";		public static final String TOKEN_EVENT = "TOKEN_EVENT";
public static final String MESSAGE_EVENT = "MESSAGE_EVENT";		public static final String MESSAGE_EVENT = "MESSAGE_EVENT";

@Override		@Override
public void onCreate() {		public void onCreate() {
super.onCreate();		super.onCreate();
CommSecureStore.getInstance().initialize(		CommSecureStore.getInstance().initialize(
ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));		ExpoUtils.createExpoSecureStoreSupplier(this.getApplicationContext()));
notificationManager = (NotificationManager)this.getSystemService(		notificationManager = (NotificationManager)this.getSystemService(
Context.NOTIFICATION_SERVICE);		Context.NOTIFICATION_SERVICE);
localBroadcastManager = LocalBroadcastManager.getInstance(this);		localBroadcastManager = LocalBroadcastManager.getInstance(this);
displayableNotificationLargeIcon = BitmapFactory.decodeResource(		displayableNotificationLargeIcon = BitmapFactory.decodeResource(
this.getApplicationContext().getResources(), R.mipmap.ic_launcher);		this.getApplicationContext().getResources(), R.mipmap.ic_launcher);
blobClient = new CommAndroidBlobClient();		servicesClient = new CommAndroidServicesClient();
aesCryptoModule = new AESCryptoModuleCompat();		aesCryptoModule = new AESCryptoModuleCompat();
}		}

@Override		@Override
public void onNewToken(String token) {		public void onNewToken(String token) {
Intent intent = new Intent(TOKEN_EVENT);		Intent intent = new Intent(TOKEN_EVENT);
intent.putExtra("token", token);		intent.putExtra("token", token);
localBroadcastManager.sendBroadcast(intent);		localBroadcastManager.sendBroadcast(intent);
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines	if (rawMessageInfosString != null && sqliteFile.exists()) {
Log.w("COMM", "Database not existing yet. Skipping notification");		Log.w("COMM", "Database not existing yet. Skipping notification");
}		}
}		}

private void handleLargeNotification(RemoteMessage message) {		private void handleLargeNotification(RemoteMessage message) {
String blobHash = message.getData().get(BLOB_HASH_KEY);		String blobHash = message.getData().get(BLOB_HASH_KEY);
String blobHolder = message.getData().get(BLOB_HOLDER_KEY);		String blobHolder = message.getData().get(BLOB_HOLDER_KEY);
try {		try {
byte[] largePayload = blobClient.getBlobSync(blobHash);		byte[] largePayload = servicesClient.getBlobSync(blobHash);
message = aesDecryptRemoteMessage(message, largePayload);		message = aesDecryptRemoteMessage(message, largePayload);
handleMessageInfosPersistence(message);		handleMessageInfosPersistence(message);
} catch (Exception e) {		} catch (Exception e) {
Log.w("COMM", "Failure when handling large notification.", e);		Log.w("COMM", "Failure when handling large notification.", e);
}		}
blobClient.scheduleDeferredBlobDeletion(		servicesClient.scheduleDeferredBlobDeletion(
blobHash, blobHolder, this.getApplicationContext());		blobHash, blobHolder, this.getApplicationContext());
}		}

private void addToThreadGroupAndDisplay(		private void addToThreadGroupAndDisplay(
String notificationID,		String notificationID,
NotificationCompat.Builder notificationBuilder,		NotificationCompat.Builder notificationBuilder,
String threadID) {		String threadID) {

▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines

[lib] Create a selector that checks if a user is logged in to a keyserverClosedPublicActions