[lib] Clear connection issue on successful login
ClosedPublic
Actions

Authored by tomek on Jan 26 2024, 8:51 AM.

Details

Reviewers

inka
kamil
varun

Commits

rCOMMee45a9d54c10: [lib] Clear connection issue on successful login

Summary

After successful auth we can conclude that a connection issue no longer exists

https://linear.app/comm/issue/ENG-6027/reset-connectionissue-field

Depends on D10842

Test Plan

Log out, dispatch an action that sets a connection issue, log in - the connection issue should be cleared.

Diff Detail

Repository

rCOMM Comm

Branch

handlers-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jan 26 2024, 8:51 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2024, 8:51 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 26 2024, 8:57 AM

Harbormaster failed remote builds in B26198: Diff 36186!

tomek added a child revision: D10844: [lib] Retry auth.Jan 26 2024, 9:12 AM

Harbormaster completed remote builds in B26198: Diff 36186.Jan 26 2024, 9:16 AM

tomek requested review of this revision.Jan 26 2024, 9:16 AM

looks fine to me but someone else should take a look

inka accepted this revision.Jan 30 2024, 1:09 AM

This revision is now accepted and ready to land.Jan 30 2024, 1:09 AM

Rebase

Harbormaster completed remote builds in B26422: Diff 36533.Feb 1 2024, 9:27 AM

Closed by commit rCOMMee45a9d54c10: [lib] Clear connection issue on successful login (authored by tomek). · Explain WhyFeb 5 2024, 7:23 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMee45a9d54c10: [lib] Clear connection issue on successful login.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

4 lines

Diff 36186

View Options

lib/reducers/keyserver-reducer.js

[lib] Clear connection issue on successful loginClosedPublicActions