Page MenuHomePhabricator
Differential D10878

[lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of lib tunnelbroker into shared websocket folder
ClosedPublic
Actions

Authored by will on Jan 30 2024, 11:03 AM.
Tags
None
Referenced Files
F6182126: D10878.id.diff
Wed, Apr 23, 7:25 AM
F6181890: D10878.id.diff
Wed, Apr 23, 7:16 AM
Unknown Object (File)
Tue, Apr 22, 11:25 AM
Unknown Object (File)
Tue, Apr 22, 10:57 AM
Unknown Object (File)
Tue, Apr 22, 3:26 AM
Unknown Object (File)
Fri, Apr 18, 10:05 PM
Unknown Object (File)
Mar 23 2025, 12:57 PM
Unknown Object (File)
Mar 22 2025, 5:46 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
kamil
Commits
rCOMM709acb05015e: [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of…
Summary

Similar to what was done for ConnectionInitializationResponse/Status and Heartbeat rust implementations in Shared, we've moved their javascript types into a shared websocket folder for usage by identity search types

Depends on D10875

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/prefix-client
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Jan 30 2024, 11:03 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 30 2024, 11:03 AM
will retitled this revision from [services] Move ConnectionInitializationResponse and Heartbeat types out of lib tunnelbroker into shared websocket folder to [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of lib tunnelbroker into shared websocket folder.Jan 30 2024, 11:04 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 30 2024, 11:20 AM
Harbormaster failed remote builds in B26312: Diff 36360!
will updated this revision to Diff 36361.Jan 30 2024, 12:04 PM

Fix flow error in keyserver

Harbormaster completed remote builds in B26313: Diff 36361.Jan 30 2024, 12:23 PM
will requested review of this revision.Jan 30 2024, 12:23 PM
bartek accepted this revision.Jan 31 2024, 2:27 AM
bartek added 1 blocking reviewer(s): kamil.
kamil accepted this revision.Jan 31 2024, 2:35 AM
This revision is now accepted and ready to land.Jan 31 2024, 2:35 AM
ashoat added a comment.Jan 31 2024, 8:30 AM

Looks like the stack is missing here

will edited the summary of this revision. (Show Details)Jan 31 2024, 8:44 AM
will added a parent revision: D10875: [identity] [8/n] Implement Heartbeats on identity search ws server.
will updated this revision to Diff 36428.Jan 31 2024, 10:39 AM

git rebase

Harbormaster completed remote builds in B26357: Diff 36428.Jan 31 2024, 10:58 AM
will added a child revision: D10903: [identity] [10/n] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgraded>, Message>>> with custom type WebsocketSink.Jan 31 2024, 2:22 PM
Closed by commit rCOMM709acb05015e: [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of… (authored by will). · Explain WhyJan 31 2024, 2:52 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM709acb05015e: [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of….

Revision Contents
Changeset List

Diff 36360

View Options

lib/tunnelbroker/tunnelbroker-context.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/tunnelbroker/connection-initialization-response-types.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/tunnelbroker/heartbeat-types.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/tunnelbroker/messages.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/websocket/connection-initialization-response-types.js

Loading...
View Options

lib/types/websocket/heartbeat-types.js

Loading...