Differential D11078

[identity] introduce RegisterWalletUser RPC
ClosedPublic
Actions

Authored by varun on Feb 14 2024, 10:04 AM.

Tags

None

Referenced Files

	F3382851: D11078.diff
	Thu, Nov 28, 12:22 PM

	Unknown Object (File)
	Mon, Nov 25, 1:19 AM

	Unknown Object (File)
	Sun, Nov 24, 10:24 PM

	Unknown Object (File)
	Thu, Nov 7, 2:19 AM

	Unknown Object (File)
	Oct 15 2024, 6:20 PM

	Unknown Object (File)
	Oct 15 2024, 6:20 PM

	Unknown Object (File)
	Oct 15 2024, 6:20 PM

	Unknown Object (File)
	Oct 15 2024, 6:20 PM

View All 57 Files

Subscribers

Details

Reviewers

ashoat
bartek

Commits

rCOMMca0a5351d647: [identity] introduce RegisterWalletUser RPC

Summary

the existing LogInWalletUser RPC now handles login exclusively. Thew new Register RPC will handle registration exclusively. Changes in this diff:

Introduced new RPC in .proto file and renamed WalletLoginRequest -> WalletAuthRequest so we can use it for both registration and login
Implemented the new register RPC on the identity service, and updated the existing login RPC to only handle login
Updated grpc-web codegen to reflect the .proto changes
Updated the native_rust_library to use the new WalletAuthRequest message name

Depends on D11062

Test Plan

confirmed that web flow check passes and native_rust_library and identity build successfully. will test the wallet RPCs further in the stack starting with D11005

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 14 2024, 10:04 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 14 2024, 10:04 AM

Harbormaster completed remote builds in B26836: Diff 37099.Feb 14 2024, 10:20 AM

varun requested review of this revision.Feb 14 2024, 10:20 AM

varun added a child revision: D11079: [lib][native] rename registerUser -> registerPasswordUser.Feb 14 2024, 10:26 AM

ashoat accepted this revision.Feb 14 2024, 12:44 PM

fix the access token metadata for wallet login and registration

Harbormaster completed remote builds in B26949: Diff 37292.Feb 15 2024, 9:35 PM

bartek accepted this revision.Feb 15 2024, 10:26 PM

bartek added inline comments.

services/identity/src/client_service.rs
487 ↗	(On Diff #37292)	When D11072 gets landed, can you rebase and use it here?

This revision is now accepted and ready to land.Feb 15 2024, 10:26 PM

varun added inline comments.Feb 16 2024, 7:14 AM

services/identity/src/client_service.rs
487 ↗	(On Diff #37292)	yeah good call

Closed by commit rCOMMca0a5351d647: [identity] introduce RegisterWalletUser RPC (authored by varun). · Explain WhyFeb 16 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMca0a5351d647: [identity] introduce RegisterWalletUser RPC.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

4 lines

services/

identity/

src/

client_service.rs

178 lines

4 lines

shared/

protos/

identity_unauth.proto

5 lines

web/

grpc/

identity-service-client-wrapper.js

4 lines

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

22 lines

identity-unauth.cjs

identity-unauth.cjs.flow

16 lines

Diff 37307

native/native_rust_library/src/lib.rs

Loading...

services/identity/src/client_service.rs

Loading...

services/identity/src/grpc_utils.rs

Loading...

shared/protos/identity_unauth.proto

Loading...

web/grpc/identity-service-client-wrapper.js

Loading...

web/protobufs/identity-unauth-structs.cjs

Loading...

web/protobufs/identity-unauth-structs.cjs.flow

Loading...

web/protobufs/identity-unauth.cjs

Loading...

web/protobufs/identity-unauth.cjs.flow

Loading...