Page MenuHomePhabricator
Differential D11424

[native][web] read synced metadata on app startup
ClosedPublic
Actions

Authored by will on Mar 27 2024, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Thu, Mar 27, 3:20 PM
Unknown Object (File)
Thu, Mar 27, 1:54 PM
Unknown Object (File)
Thu, Mar 27, 5:40 AM
Unknown Object (File)
Thu, Mar 27, 3:18 AM
Unknown Object (File)
Wed, Mar 26, 1:38 PM
Unknown Object (File)
Thu, Mar 20, 8:09 AM
Unknown Object (File)
Wed, Mar 19, 3:46 PM
View All 92 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
ginsu
atul
Commits
rCOMM5c58ffedf293: [native][web] read synced metadata on app startup
Summary

This gets the synced metadata from sqlite and populates the redux store

Depends on D11422

Test Plan

Confirmed on web app that the sqlite db and the redux store are the same:

image.png (778×1 px, 165 KB)

image.png (264×780 px, 49 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mar 27 2024, 5:29 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 5:29 PM
will edited the test plan for this revision. (Show Details)Mar 27 2024, 5:31 PM
will edited the summary of this revision. (Show Details)
will added a parent revision: D11422: [lib/native/web] introduce synced metadata reducer.
Harbormaster completed remote builds in B27743: Diff 38406.Mar 27 2024, 5:44 PM
will requested review of this revision.Mar 27 2024, 5:44 PM
ashoat mentioned this in D11425: [lib][native] FIDProvider.Mar 27 2024, 5:47 PM
kamil accepted this revision.Mar 28 2024, 5:06 AM
This revision is now accepted and ready to land.Mar 28 2024, 5:06 AM
ashoat mentioned this in rCOMM652a137d6429: [lib][native] FIDProvider.Mar 28 2024, 5:07 AM
will updated this revision to Diff 38687.Apr 2 2024, 10:47 PM
will edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B27925: Diff 38687.Apr 2 2024, 11:03 PM
Closed by commit rCOMM5c58ffedf293: [native][web] read synced metadata on app startup (authored by will). · Explain WhyApr 2 2024, 11:22 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM5c58ffedf293: [native][web] read synced metadata on app startup.

Revision Contents
Changeset List

PathSize
native/
data/
5 lines
web/
shared-worker/
utils/
8 lines

Diff 38697

View Options

native/data/sqlite-data-handler.js

// @flow // @flow
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { import {
getAvatarForUser, getAvatarForUser,
getRandomDefaultEmojiAvatar, getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js'; } from '../shared/avatar-utils.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { import type {
MinimallyEncodedRelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
RawThreadInfos, RawThreadInfos,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines if (isViewer) {
relativeMemberInfos.unshift(relativeMemberInfo); relativeMemberInfos.unshift(relativeMemberInfo);
} else { } else {
relativeMemberInfos.push(relativeMemberInfo); relativeMemberInfos.push(relativeMemberInfo);
} }
} }
return relativeMemberInfos; return relativeMemberInfos;
} }
const emptyArray: $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = []; const emptyArray: $ReadOnlyArray<RelativeMemberInfo> = [];
// Includes current user at the start // Includes current user at the start
const baseRelativeMemberInfoSelectorForMembersOfThread: ( const baseRelativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string, threadID: ?string,
) => ( ) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = (
state: BaseAppState<>,
) => $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = (
threadID: ?string, threadID: ?string,
) => { ) => {
if (!threadID) { if (!threadID) {
return () => emptyArray; return () => emptyArray;
} }
return createSelector( return createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
(state: BaseAppState<>) => (state: BaseAppState<>) =>
state.currentUserInfo && state.currentUserInfo.id, state.currentUserInfo && state.currentUserInfo.id,
(state: BaseAppState<>) => state.userStore.userInfos, (state: BaseAppState<>) => state.userStore.userInfos,
getRelativeMemberInfos, getRelativeMemberInfos,
); );
}; };
const relativeMemberInfoSelectorForMembersOfThread: ( const relativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string, threadID: ?string,
) => ( ) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = _memoize(
state: BaseAppState<>,
) => $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = _memoize(
baseRelativeMemberInfoSelectorForMembersOfThread, baseRelativeMemberInfoSelectorForMembersOfThread,
); );
const userInfoSelectorForPotentialMembers: (state: BaseAppState<>) => { const userInfoSelectorForPotentialMembers: (state: BaseAppState<>) => {
[id: string]: AccountUserInfo, [id: string]: AccountUserInfo,
} = createSelector( } = createSelector(
(state: BaseAppState<>) => state.userStore.userInfos, (state: BaseAppState<>) => state.userStore.userInfos,
(state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id, (state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id,
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines
View Options

web/shared-worker/utils/store.js

// @flow // @flow
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { import {
getAvatarForUser, getAvatarForUser,
getRandomDefaultEmojiAvatar, getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js'; } from '../shared/avatar-utils.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { import type {
MinimallyEncodedRelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
RawThreadInfos, RawThreadInfos,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines if (isViewer) {
relativeMemberInfos.unshift(relativeMemberInfo); relativeMemberInfos.unshift(relativeMemberInfo);
} else { } else {
relativeMemberInfos.push(relativeMemberInfo); relativeMemberInfos.push(relativeMemberInfo);
} }
} }
return relativeMemberInfos; return relativeMemberInfos;
} }
const emptyArray: $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = []; const emptyArray: $ReadOnlyArray<RelativeMemberInfo> = [];
// Includes current user at the start // Includes current user at the start
const baseRelativeMemberInfoSelectorForMembersOfThread: ( const baseRelativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string, threadID: ?string,
) => ( ) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = (
state: BaseAppState<>,
) => $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = (
threadID: ?string, threadID: ?string,
) => { ) => {
if (!threadID) { if (!threadID) {
return () => emptyArray; return () => emptyArray;
} }
return createSelector( return createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
(state: BaseAppState<>) => (state: BaseAppState<>) =>
state.currentUserInfo && state.currentUserInfo.id, state.currentUserInfo && state.currentUserInfo.id,
(state: BaseAppState<>) => state.userStore.userInfos, (state: BaseAppState<>) => state.userStore.userInfos,
getRelativeMemberInfos, getRelativeMemberInfos,
); );
}; };
const relativeMemberInfoSelectorForMembersOfThread: ( const relativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string, threadID: ?string,
) => ( ) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = _memoize(
state: BaseAppState<>,
) => $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = _memoize(
baseRelativeMemberInfoSelectorForMembersOfThread, baseRelativeMemberInfoSelectorForMembersOfThread,
); );
const userInfoSelectorForPotentialMembers: (state: BaseAppState<>) => { const userInfoSelectorForPotentialMembers: (state: BaseAppState<>) => {
[id: string]: AccountUserInfo, [id: string]: AccountUserInfo,
} = createSelector( } = createSelector(
(state: BaseAppState<>) => state.userStore.userInfos, (state: BaseAppState<>) => state.userStore.userInfos,
(state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id, (state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id,
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines