Page MenuHomePhabricator
Differential D11576

[native/sqlite] Create thread activity table in sqlite
ClosedPublic
Actions

Authored by will on Apr 8 2024, 6:18 AM.
Tags
None
Referenced Files
F3374202: D11576.diff
Tue, Nov 26, 2:24 PM
Unknown Object (File)
Mon, Oct 28, 7:49 PM
Unknown Object (File)
Oct 25 2024, 1:18 AM
Unknown Object (File)
Oct 18 2024, 9:43 PM
Unknown Object (File)
Oct 2 2024, 12:32 PM
Unknown Object (File)
Sep 21 2024, 9:54 PM
Unknown Object (File)
Sep 15 2024, 8:11 AM
Unknown Object (File)
Sep 9 2024, 1:05 AM
View All 26 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
atul
ginsu
Commits
rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite
Summary

Initializes the sqlite table for thread activity

Depends on D11575

Test Plan

Verified on database explorer the table was being created

Tested create_schema by building on new target

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Apr 8 2024, 6:18 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 8 2024, 6:18 AM
will edited the summary of this revision. (Show Details)Apr 8 2024, 6:18 AM
will added a parent revision: D11575: [lib] Add thread activity store ops.
will added a child revision: D11578: [lib] refactor thread activity reducer to use sqlite operations.Apr 8 2024, 6:25 AM
Harbormaster completed remote builds in B28046: Diff 38896.Apr 8 2024, 6:33 AM
will requested review of this revision.Apr 8 2024, 6:33 AM
atul accepted this revision.Apr 8 2024, 10:27 AM

Would be good to include both create_schema and migration flow in Test Plan

This revision is now accepted and ready to land.Apr 8 2024, 10:27 AM
will added a comment.Apr 8 2024, 10:32 AM
In D11576#333165, @atul wrote:

Would be good to include both create_schema and migration flow in Test Plan

Cool. I'll add create_schema to this test plan. The migration flow I'll test in later diffs

will edited the test plan for this revision. (Show Details)Apr 15 2024, 5:14 AM
Closed by commit rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite (authored by will). · Explain WhyApr 19 2024, 12:32 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines
web/
shared-worker/
_generated/

Diff 39313

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...