Page MenuHomePhabricator
Differential D11576

[native/sqlite] Create thread activity table in sqlite
ClosedPublic
Actions

Authored by will on Apr 8 2024, 6:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 1:18 AM
Unknown Object (File)
Tue, Mar 18, 7:52 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
Unknown Object (File)
Feb 16 2025, 4:25 AM
Unknown Object (File)
Feb 16 2025, 4:25 AM
Unknown Object (File)
Feb 16 2025, 4:25 AM
Unknown Object (File)
Jan 28 2025, 10:35 PM
Unknown Object (File)
Jan 23 2025, 4:15 AM
View All 39 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
atul
ginsu
Commits
rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite
Summary

Initializes the sqlite table for thread activity

Depends on D11575

Test Plan

Verified on database explorer the table was being created

Tested create_schema by building on new target

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Apr 8 2024, 6:18 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 8 2024, 6:18 AM
will edited the summary of this revision. (Show Details)Apr 8 2024, 6:18 AM
will added a parent revision: D11575: [lib] Add thread activity store ops.
will added a child revision: D11578: [lib] refactor thread activity reducer to use sqlite operations.Apr 8 2024, 6:25 AM
Harbormaster completed remote builds in B28046: Diff 38896.Apr 8 2024, 6:33 AM
will requested review of this revision.Apr 8 2024, 6:33 AM
atul accepted this revision.Apr 8 2024, 10:27 AM

Would be good to include both create_schema and migration flow in Test Plan

This revision is now accepted and ready to land.Apr 8 2024, 10:27 AM
will added a comment.Apr 8 2024, 10:32 AM
In D11576#333165, @atul wrote:

Would be good to include both create_schema and migration flow in Test Plan

Cool. I'll add create_schema to this test plan. The migration flow I'll test in later diffs

will edited the test plan for this revision. (Show Details)Apr 15 2024, 5:14 AM
Closed by commit rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite (authored by will). · Explain WhyApr 19 2024, 12:32 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines
web/
shared-worker/
_generated/

Diff 38896

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
updateRelationships as serverUpdateRelationships, updateRelationships as serverUpdateRelationships,
updateRelationshipsActionTypes, updateRelationshipsActionTypes,
} from '../actions/relationship-actions.js'; } from '../actions/relationship-actions.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
type RelationshipAction,
relationshipActions, relationshipActions,
type TraditionalRelationshipAction,
} from '../types/relationship-types.js'; } from '../types/relationship-types.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
type RelationshipCallbacks = { type RelationshipCallbacks = {
+blockUser: () => void, +blockUser: () => void,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
function useRelationshipCallbacks( function useRelationshipCallbacks(
otherUserID?: string, otherUserID?: string,
onErrorCallback?: () => void, onErrorCallback?: () => void,
): RelationshipCallbacks { ): RelationshipCallbacks {
const callUpdateRelationships = useLegacyAshoatKeyserverCall( const callUpdateRelationships = useLegacyAshoatKeyserverCall(
serverUpdateRelationships, serverUpdateRelationships,
); );
const updateRelationship = React.useCallback( const updateRelationship = React.useCallback(
async (action: RelationshipAction) => { async (action: TraditionalRelationshipAction) => {
try { try {
invariant(otherUserID, 'Other user info id should be present'); invariant(otherUserID, 'Other user info id should be present');
return await callUpdateRelationships({ return await callUpdateRelationships({
action, action,
userIDs: [otherUserID], userIDs: [otherUserID],
}); });
} catch (e) { } catch (e) {
onErrorCallback?.(); onErrorCallback?.();
throw e; throw e;
} }
}, },
[callUpdateRelationships, onErrorCallback, otherUserID], [callUpdateRelationships, onErrorCallback, otherUserID],
); );
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const onButtonPress = React.useCallback( const onButtonPress = React.useCallback(
(action: RelationshipAction) => { (action: TraditionalRelationshipAction) => {
void dispatchActionPromise( void dispatchActionPromise(
updateRelationshipsActionTypes, updateRelationshipsActionTypes,
updateRelationship(action), updateRelationship(action),
); );
}, },
[dispatchActionPromise, updateRelationship], [dispatchActionPromise, updateRelationship],
); );
Show All 29 Lines
View Options

web/shared-worker/_generated/comm_query_executor.wasm

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
updateRelationships as serverUpdateRelationships, updateRelationships as serverUpdateRelationships,
updateRelationshipsActionTypes, updateRelationshipsActionTypes,
} from '../actions/relationship-actions.js'; } from '../actions/relationship-actions.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
type RelationshipAction,
relationshipActions, relationshipActions,
type TraditionalRelationshipAction,
} from '../types/relationship-types.js'; } from '../types/relationship-types.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
type RelationshipCallbacks = { type RelationshipCallbacks = {
+blockUser: () => void, +blockUser: () => void,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
function useRelationshipCallbacks( function useRelationshipCallbacks(
otherUserID?: string, otherUserID?: string,
onErrorCallback?: () => void, onErrorCallback?: () => void,
): RelationshipCallbacks { ): RelationshipCallbacks {
const callUpdateRelationships = useLegacyAshoatKeyserverCall( const callUpdateRelationships = useLegacyAshoatKeyserverCall(
serverUpdateRelationships, serverUpdateRelationships,
); );
const updateRelationship = React.useCallback( const updateRelationship = React.useCallback(
async (action: RelationshipAction) => { async (action: TraditionalRelationshipAction) => {
try { try {
invariant(otherUserID, 'Other user info id should be present'); invariant(otherUserID, 'Other user info id should be present');
return await callUpdateRelationships({ return await callUpdateRelationships({
action, action,
userIDs: [otherUserID], userIDs: [otherUserID],
}); });
} catch (e) { } catch (e) {
onErrorCallback?.(); onErrorCallback?.();
throw e; throw e;
} }
}, },
[callUpdateRelationships, onErrorCallback, otherUserID], [callUpdateRelationships, onErrorCallback, otherUserID],
); );
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const onButtonPress = React.useCallback( const onButtonPress = React.useCallback(
(action: RelationshipAction) => { (action: TraditionalRelationshipAction) => {
void dispatchActionPromise( void dispatchActionPromise(
updateRelationshipsActionTypes, updateRelationshipsActionTypes,
updateRelationship(action), updateRelationship(action),
); );
}, },
[dispatchActionPromise, updateRelationship], [dispatchActionPromise, updateRelationship],
); );
Show All 29 Lines