Paths

Table of Contentst

Differential D11603

[lib] Rename `sansFarcaster` variable names and types to `Traditional*`
ClosedPublic
Actions

Authored by atul on Apr 10 2024, 1:40 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

ginsu
tomek
will
varun

Commits

rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`

Summary

Including farcaster in all of these types and variables when it's often completely irrelevant doesn't make sense. Calling them Legacy* doesn't quite make sense either since they're def not being phased out, so settled on Traditional* to keep consistent with D11602

Depends on D11602

Test Plan

NA, simple rename

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 10 2024, 1:40 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 10 2024, 1:40 AM

Harbormaster completed remote builds in B28103: Diff 38959.Apr 10 2024, 1:59 AM

atul requested review of this revision.Apr 10 2024, 1:59 AM

atul added a child revision: D11604: [keyserver] Update `updateRelationshipInputValidator` to accept both traditional/farcaster requests.Apr 10 2024, 2:50 AM

atul added a child revision: D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.Apr 10 2024, 3:06 AM

ginsu accepted this revision.Apr 10 2024, 5:06 AM

This revision is now accepted and ready to land.Apr 10 2024, 5:06 AM

land

This revision was landed with ongoing or failed builds.Apr 10 2024, 6:51 PM

Closed by commit rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.

Harbormaster completed remote builds in B28133: Diff 38997.Apr 10 2024, 6:55 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

relationship-types.js

8 lines

Diff 38998

lib/types/relationship-types.js

Loading...