Page MenuHomePhabricator
Differential D11604

[keyserver] Update `updateRelationshipInputValidator` to accept both traditional/farcaster requests
AbandonedPublicDraft
Actions

Authored by atul on Apr 9 2024, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 9:42 AM
Unknown Object (File)
Fri, Mar 14, 9:53 PM
Unknown Object (File)
Fri, Mar 14, 10:57 AM
Unknown Object (File)
Sat, Mar 8, 2:06 AM
Unknown Object (File)
Sat, Mar 8, 2:05 AM
Unknown Object (File)
Sat, Mar 8, 2:05 AM
Unknown Object (File)
Feb 10 2025, 8:29 PM
Unknown Object (File)
Jan 13 2025, 7:18 PM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
varun
ginsu
will
tomek
Summary

Update updateRelationshipInputValidator to support both traditional and farcaster requests.

Changes will still need to be made within responder to handle farcaster requests, this just ensures that validation won't fail.

Depends on D11603

Test Plan

Tested implicitly by traditional/farcaster requests later in the stack. Could also add unit tests.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
8 lines

Diff 38960

View Options

keyserver/src/responders/relationship-responders.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines size_t decryptedSize = ::olm_decrypt(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt => " + std::string{::olm_session_last_error(session)} + "error decrypt => " + std::string{::olm_session_last_error(session)} +
". Hash: " + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
std::string Session::decryptSequential(EncryptedData &encryptedData) { std::string Session::decryptSequential(EncryptedData &encryptedData) {
OlmSession *session = this->getOlmSession(); OlmSession *session = this->getOlmSession();
OlmBuffer utilityBuffer(::olm_utility_size()); OlmBuffer utilityBuffer(::olm_utility_size());
OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data()); OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data());
Show All 28 Lines size_t decryptedSize = ::olm_decrypt_sequential(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt_sequential => " + "error decrypt_sequential => " +
std::string{::olm_session_last_error(session)} + ". Hash: " + std::string{::olm_session_last_error(session)} + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
int Session::getVersion() { int Session::getVersion() {
return this->version; return this->version;
} }
void Session::setVersion(int newVersion) { void Session::setVersion(int newVersion) {
this->version = newVersion; this->version = newVersion;
} }
} // namespace crypto } // namespace crypto
} // namespace comm } // namespace comm