Page MenuHomePhabricator

[lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`
ClosedPublic

Authored by atul on Apr 11 2024, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 11:09 PM
Unknown Object (File)
Nov 24 2024, 8:55 AM
Unknown Object (File)
Nov 24 2024, 7:46 AM
Unknown Object (File)
Nov 19 2024, 2:26 PM
Unknown Object (File)
Nov 3 2024, 9:48 AM
Unknown Object (File)
Oct 12 2024, 11:29 PM
Unknown Object (File)
Oct 12 2024, 11:29 PM
Unknown Object (File)
Oct 12 2024, 11:29 PM
Subscribers

Details

Summary

Pretty straightforward, the UpdateFarcasterMessageData variant includes creatorFID and targetFID.

Considered something like

+userIDsToFID: { +[userID: string]: string },

for consistency with FarcasterRelationshipRequest, but think this approach is cleaner and we don't need validators/etc to ensure that there are only two entries in userIDsToFID, etc.


Depends on D11624

Test Plan

flow + CI

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Apr 11 2024, 8:06 PM
atul edited the summary of this revision. (Show Details)
tomek added inline comments.
lib/types/messages/update-relationship.js
15–24 ↗(On Diff #39070)
This revision is now accepted and ready to land.Apr 12 2024, 2:39 AM
lib/types/messages/update-relationship.js
15–24 ↗(On Diff #39070)

Thanks for catching this!

This is safe to land since we don't have equivalent to https://github.com/CommE2E/comm/commit/7024301fcda748efefa900bd952cd8e127aac87d landed on master yet so these messages aren't currently getting created.

This revision was landed with ongoing or failed builds.Apr 17 2024, 12:42 PM
This revision was automatically updated to reflect the committed changes.