[lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual`
ClosedPublic
Actions

Authored by atul on Apr 12 2024, 12:52 PM.

Details

Reviewers

ginsu
tomek
will
varun

Commits

rCOMM0b125c91012d: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle…

Summary

Include creatorFID and targetFID in returned RawUpdateRelationshipMessageInfo

Depends on D11651

Test Plan

Will log value of RawUpdateRelationshipMessageInfo at callsite when operation is farcaster_mutual and ensure that it looks as expected.

Will also be tested implicitly by the rest of the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 12 2024, 12:52 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 12 2024, 12:53 PM

atul published this revision for review.Apr 12 2024, 12:59 PM

Harbormaster completed remote builds in B28200: Diff 39090.Apr 12 2024, 1:11 PM

atul added a child revision: D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual`.Apr 12 2024, 1:12 PM

tomek accepted this revision.Apr 15 2024, 1:37 AM

This revision is now accepted and ready to land.Apr 15 2024, 1:37 AM

land

This revision was landed with ongoing or failed builds.Apr 18 2024, 1:05 PM

Closed by commit rCOMM0b125c91012d: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0b125c91012d: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle….

Harbormaster completed remote builds in B28305: Diff 39244.Apr 18 2024, 1:31 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

15 lines

Diff 39245

View Options

lib/shared/messages/update-relationship-message-spec.js

[lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual`ClosedPublicActions