Page MenuHomePhabricator
Differential D11669

[native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages
ClosedPublic
Actions

Authored by atul on Tue, Apr 16, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 4:53 AM
Unknown Object (File)
Sun, Apr 28, 4:29 AM
Unknown Object (File)
Sat, Apr 27, 12:17 PM
Unknown Object (File)
Sat, Apr 27, 3:12 AM
Unknown Object (File)
Sat, Apr 27, 3:12 AM
Unknown Object (File)
Fri, Apr 26, 5:01 PM
Unknown Object (File)
Fri, Apr 26, 3:40 PM
Unknown Object (File)
Tue, Apr 23, 11:30 AM
View All 17 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
will
Commits
rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages
Summary

In the stack that begins D11606 we update the "shape" of UPDATE_RELATIONSHIP messages so they include FIDs when the operation is farcaster_mutual.

This migration clears out any existing unsupported UPDATE_RELATIONSHIP messages that developers may have in their local environments.

Depends on D11653

Test Plan

Before migration:

7c2c62.png (552×1 px, 122 KB)

After migration:

a4f99f.png (228×1 px, 57 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Tue, Apr 16, 12:23 PM
atul edited the test plan for this revision. (Show Details)Tue, Apr 16, 12:24 PM
atul published this revision for review.Tue, Apr 16, 12:27 PM
atul added inline comments.
native/redux/persist.js
1227 ↗(On Diff #39160)

All ClientDB* fields are typed as string, so we parseInt to be able to compare to messageTypes constants.

The reason we have parseInt here is because we're not converting from ClientDBMessageInfo -> RawMessageInfo -> ClientDBMessageInfo as we often do.

ashoat accepted this revision.Tue, Apr 16, 12:34 PM
ashoat added inline comments.
native/redux/persist.js
1228 ↗(On Diff #39160)

Is there a possibility that some of these messages have been unshimmed? I seem to recall there are two ways for things to get unshimmed... one is when the keyserver stops shimming them, and another is when they're added to the unshim list on the client

This revision is now accepted and ready to land.Tue, Apr 16, 12:34 PM
Harbormaster failed remote builds in B28249: Diff 39160!Tue, Apr 16, 12:40 PM
atul updated this revision to Diff 39161.Tue, Apr 16, 12:43 PM
atul edited the test plan for this revision. (Show Details)

remove hack from stack

Harbormaster completed remote builds in B28250: Diff 39161.Tue, Apr 16, 12:59 PM
atul added inline comments.Wed, Apr 17, 9:34 AM
native/redux/persist.js
1228 ↗(On Diff #39160)

They haven't been added to unshim list and we have a FUTURE_CODE_VERSION code version check in update-relationship-spec

atul added a child revision: D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.Wed, Apr 17, 11:12 AM
atul mentioned this in D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.Wed, Apr 17, 11:52 AM
atul updated this revision to Diff 39299.Fri, Apr 19, 11:23 AM

rebase and land

This revision was landed with ongoing or failed builds.Fri, Apr 19, 11:37 AM
Closed by commit rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Harbormaster completed remote builds in B28335: Diff 39299.Fri, Apr 19, 11:39 AM
atul mentioned this in rCOMMfd6440e367d5: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from….Fri, Apr 19, 11:56 AM

Revision Contents
Changeset List

PathSize
native/
redux/
32 lines

Diff 39302

View Options

native/redux/persist.js

Loading...