Details

Reviewers

ashoat
ginsu
tomek
varun
will

Commits

rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages

Summary

In the stack that begins D11606 we update the "shape" of UPDATE_RELATIONSHIP messages so they include FIDs when the operation is farcaster_mutual.

This migration clears out any existing unsupported UPDATE_RELATIONSHIP messages that developers may have in their local environments.

Depends on D11653

Test Plan

Before migration:

After migration:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 16 2024, 12:23 PM

atul edited the test plan for this revision. (Show Details)Apr 16 2024, 12:24 PM

atul published this revision for review.Apr 16 2024, 12:27 PM

atul added inline comments.

native/redux/persist.js
1227	All `ClientDB*` fields are typed as `string`, so we `parseInt` to be able to compare to `messageTypes` constants. The reason we have `parseInt` here is because we're not converting from ClientDBMessageInfo -> RawMessageInfo -> ClientDBMessageInfo as we often do.

ashoat accepted this revision.Apr 16 2024, 12:34 PM

ashoat added inline comments.

native/redux/persist.js
1228	Is there a possibility that some of these messages have been unshimmed? I seem to recall there are two ways for things to get unshimmed... one is when the keyserver stops shimming them, and another is when they're added to the unshim list on the client

This revision is now accepted and ready to land.Apr 16 2024, 12:34 PM

Harbormaster failed remote builds in B28249: Diff 39160!Apr 16 2024, 12:40 PM