Page MenuHomePhabricator
Differential D11650

[lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`
ClosedPublic
Actions

Authored by atul on Fri, Apr 12, 11:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 1:24 AM
Unknown Object (File)
Sat, Apr 27, 4:50 PM
Unknown Object (File)
Sat, Apr 27, 12:23 PM
Unknown Object (File)
Sat, Apr 27, 7:19 AM
Unknown Object (File)
Fri, Apr 26, 8:32 AM
Unknown Object (File)
Sun, Apr 21, 4:13 AM
Unknown Object (File)
Thu, Apr 18, 7:12 PM
Unknown Object (File)
Thu, Apr 18, 4:44 PM
View All 13 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update…
Summary

Similar to previous diffs in stack, splitting the type to support farcaster operation.

Made necessary changes to update-relationship-message-spec as well.

Depends on D11642

Test Plan

Flow for now, will be tested implicitly by subsequent diffs where these messages are actually created/persisted/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Fri, Apr 12, 11:47 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Apr 12, 11:47 AM
Harbormaster completed remote builds in B28196: Diff 39086.Fri, Apr 12, 12:03 PM
atul requested review of this revision.Fri, Apr 12, 12:03 PM
tomek accepted this revision.Mon, Apr 15, 1:24 AM
tomek added inline comments.
lib/shared/messages/update-relationship-message-spec.js
155 ↗(On Diff #39086)

Is there a const we can use here?

219 ↗(On Diff #39086)

We probably have to introduce a shim for this new operation type

This revision is now accepted and ready to land.Mon, Apr 15, 1:24 AM
atul added a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Tue, Apr 16, 12:22 PM
atul added inline comments.Thu, Apr 18, 11:05 AM
lib/shared/messages/update-relationship-message-spec.js
155 ↗(On Diff #39086)

There's not at the moment, have a diff locally where I replace this with a constant value.

Definitely agree that hardcoding this string is not ideal and error-prone.

atul added inline comments.Thu, Apr 18, 11:07 AM
lib/shared/messages/update-relationship-message-spec.js
219 ↗(On Diff #39086)

We send UNSUPPORTED message for farcaster_mutual operation:

158a3d.png (704×876 px, 112 KB)

atul attached a referenced file: F1572505: 158a3d.png. (Show Details)Thu, Apr 18, 11:39 AM
atul updated this revision to Diff 39234.Thu, Apr 18, 11:43 AM

rebase and aldn

This revision was landed with ongoing or failed builds.Thu, Apr 18, 11:48 AM
Closed by commit rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update….
Harbormaster completed remote builds in B28298: Diff 39234.Thu, Apr 18, 11:59 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
12 lines
types/
messages/
20 lines

Diff 39235

View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...
View Options

lib/types/messages/update-relationship.js

Loading...