Page MenuHomePhabricator
Differential D11650

[lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`
ClosedPublic
Actions

Authored by atul on Apr 12 2024, 11:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 4:41 PM
Unknown Object (File)
Tue, Mar 25, 12:31 AM
Unknown Object (File)
Thu, Mar 6, 12:30 PM
Unknown Object (File)
Thu, Mar 6, 12:30 PM
Unknown Object (File)
Thu, Mar 6, 12:30 PM
Unknown Object (File)
Thu, Mar 6, 12:30 PM
Unknown Object (File)
Thu, Mar 6, 12:30 PM
Unknown Object (File)
Feb 10 2025, 12:30 PM
View All 66 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update…
Summary

Similar to previous diffs in stack, splitting the type to support farcaster operation.

Made necessary changes to update-relationship-message-spec as well.

Depends on D11642

Test Plan

Flow for now, will be tested implicitly by subsequent diffs where these messages are actually created/persisted/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 12 2024, 11:47 AM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 12 2024, 11:47 AM
Harbormaster completed remote builds in B28196: Diff 39086.Apr 12 2024, 12:03 PM
atul requested review of this revision.Apr 12 2024, 12:03 PM
tomek accepted this revision.Apr 15 2024, 1:24 AM
tomek added inline comments.
lib/shared/messages/update-relationship-message-spec.js
155 ↗(On Diff #39086)

Is there a const we can use here?

219 ↗(On Diff #39086)

We probably have to introduce a shim for this new operation type

This revision is now accepted and ready to land.Apr 15 2024, 1:24 AM
atul added a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Apr 16 2024, 12:22 PM
atul added inline comments.Apr 18 2024, 11:05 AM
lib/shared/messages/update-relationship-message-spec.js
155 ↗(On Diff #39086)

There's not at the moment, have a diff locally where I replace this with a constant value.

Definitely agree that hardcoding this string is not ideal and error-prone.

atul added inline comments.Apr 18 2024, 11:07 AM
lib/shared/messages/update-relationship-message-spec.js
219 ↗(On Diff #39086)

We send UNSUPPORTED message for farcaster_mutual operation:

158a3d.png (704×876 px, 112 KB)

atul attached a referenced file: F1572505: 158a3d.png. (Show Details)Apr 18 2024, 11:39 AM
atul updated this revision to Diff 39234.Apr 18 2024, 11:43 AM

rebase and aldn

This revision was landed with ongoing or failed builds.Apr 18 2024, 11:48 AM
Closed by commit rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update….
Harbormaster completed remote builds in B28298: Diff 39234.Apr 18 2024, 11:59 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
12 lines
types/
messages/
20 lines

Diff 39235

View Options

lib/shared/messages/update-relationship-message-spec.js

Show First 20 Lines • Show All 1,213 Lines • ▼ Show 20 Lines const newState = {
...rest, ...rest,
alertStore: { alertStore: {
alertInfos: defaultAlertInfos, alertInfos: defaultAlertInfos,
}, },
}; };
return newState; return newState;
}, },
[70]: (state: any) => {
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();
const unsupportedMessageIDsToRemove = clientDBMessageInfos
.filter(
message =>
parseInt(message.type) === messageTypes.UNSUPPORTED &&
parseInt(message.future_type) === messageTypes.UPDATE_RELATIONSHIP,
)
.map(message => message.id);
const messageStoreOperations: $ReadOnlyArray<ClientDBMessageStoreOperation> =
[
{
type: 'remove',
payload: { ids: unsupportedMessageIDsToRemove },
},
];
try {
commCoreModule.processMessageStoreOperationsSync(messageStoreOperations);
} catch (exception) {
console.log(exception);
if (isTaskCancelledError(exception)) {
return state;
}
return { ...state, cookie: null };
}
return state;
},
}; };
type PersistedReportStore = $Diff< type PersistedReportStore = $Diff<
ReportStore, ReportStore,
{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> }, { +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
>; >;
const reportStoreTransform: Transform = createTransform( const reportStoreTransform: Transform = createTransform(
(state: ReportStore): PersistedReportStore => { (state: ReportStore): PersistedReportStore => {
return { enabledReports: state.enabledReports }; return { enabledReports: state.enabledReports };
}, },
(state: PersistedReportStore): ReportStore => { (state: PersistedReportStore): ReportStore => {
return { ...state, queuedReports: [] }; return { ...state, queuedReports: [] };
}, },
{ whitelist: ['reportStore'] }, { whitelist: ['reportStore'] },
); );
const persistConfig = { const persistConfig = {
key: 'root', key: 'root',
storage: AsyncStorage, storage: AsyncStorage,
blacklist: persistBlacklist, blacklist: persistBlacklist,
debug: __DEV__, debug: __DEV__,
version: 69, version: 70,
transforms: [ transforms: [
messageStoreMessagesBlocklistTransform, messageStoreMessagesBlocklistTransform,
reportStoreTransform, reportStoreTransform,
keyserverStoreTransform, keyserverStoreTransform,
], ],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 16 Lines
View Options

lib/types/messages/update-relationship.js

Show First 20 Lines • Show All 1,213 Lines • ▼ Show 20 Lines const newState = {
...rest, ...rest,
alertStore: { alertStore: {
alertInfos: defaultAlertInfos, alertInfos: defaultAlertInfos,
}, },
}; };
return newState; return newState;
}, },
[70]: (state: any) => {
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();
const unsupportedMessageIDsToRemove = clientDBMessageInfos
.filter(
message =>
parseInt(message.type) === messageTypes.UNSUPPORTED &&
parseInt(message.future_type) === messageTypes.UPDATE_RELATIONSHIP,
)
.map(message => message.id);
const messageStoreOperations: $ReadOnlyArray<ClientDBMessageStoreOperation> =
[
{
type: 'remove',
payload: { ids: unsupportedMessageIDsToRemove },
},
];
try {
commCoreModule.processMessageStoreOperationsSync(messageStoreOperations);
} catch (exception) {
console.log(exception);
if (isTaskCancelledError(exception)) {
return state;
}
return { ...state, cookie: null };
}
return state;
},
}; };
type PersistedReportStore = $Diff< type PersistedReportStore = $Diff<
ReportStore, ReportStore,
{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> }, { +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
>; >;
const reportStoreTransform: Transform = createTransform( const reportStoreTransform: Transform = createTransform(
(state: ReportStore): PersistedReportStore => { (state: ReportStore): PersistedReportStore => {
return { enabledReports: state.enabledReports }; return { enabledReports: state.enabledReports };
}, },
(state: PersistedReportStore): ReportStore => { (state: PersistedReportStore): ReportStore => {
return { ...state, queuedReports: [] }; return { ...state, queuedReports: [] };
}, },
{ whitelist: ['reportStore'] }, { whitelist: ['reportStore'] },
); );
const persistConfig = { const persistConfig = {
key: 'root', key: 'root',
storage: AsyncStorage, storage: AsyncStorage,
blacklist: persistBlacklist, blacklist: persistBlacklist,
debug: __DEV__, debug: __DEV__,
version: 69, version: 70,
transforms: [ transforms: [
messageStoreMessagesBlocklistTransform, messageStoreMessagesBlocklistTransform,
reportStoreTransform, reportStoreTransform,
keyserverStoreTransform, keyserverStoreTransform,
], ],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 16 Lines