Paths

Table of Contentst

[lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`
ClosedPublic
Actions

Authored by atul on Apr 12 2024, 11:47 AM.

Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update…

Summary

Similar to previous diffs in stack, splitting the type to support farcaster operation.

Made necessary changes to update-relationship-message-spec as well.

Depends on D11642

Test Plan

Flow for now, will be tested implicitly by subsequent diffs where these messages are actually created/persisted/etc.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 12 2024, 11:47 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 12 2024, 11:47 AM

Harbormaster completed remote builds in B28196: Diff 39086.Apr 12 2024, 12:03 PM

atul requested review of this revision.Apr 12 2024, 12:03 PM

tomek accepted this revision.Apr 15 2024, 1:24 AM

tomek added inline comments.

lib/shared/messages/update-relationship-message-spec.js
155 ↗	(On Diff #39086)	Is there a const we can use here?
219 ↗	(On Diff #39086)	We probably have to introduce a `shim` for this new operation type

This revision is now accepted and ready to land.Apr 15 2024, 1:24 AM

atul added a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Apr 16 2024, 12:22 PM

atul added inline comments.Apr 18 2024, 11:05 AM

lib/shared/messages/update-relationship-message-spec.js
155 ↗	(On Diff #39086)	There's not at the moment, have a diff locally where I replace this with a constant value. Definitely agree that hardcoding this string is not ideal and error-prone.

atul added inline comments.Apr 18 2024, 11:07 AM

lib/shared/messages/update-relationship-message-spec.js
219 ↗	(On Diff #39086)	We send `UNSUPPORTED` message for `farcaster_mutual` operation:

atul attached a referenced file: F1572505: 158a3d.png. (Show Details)Apr 18 2024, 11:39 AM

rebase and aldn

This revision was landed with ongoing or failed builds.Apr 18 2024, 11:48 AM

Closed by commit rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update….

Harbormaster completed remote builds in B28298: Diff 39234.Apr 18 2024, 11:59 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

12 lines

types/

messages/

update-relationship.js

20 lines

Diff 39235

View Options

lib/shared/messages/update-relationship-message-spec.js