Page MenuHomePhabricator
Differential D11604

[keyserver] Update `updateRelationshipInputValidator` to accept both traditional/farcaster requests
AbandonedPublicDraft
Actions

Authored by atul on Apr 9 2024, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 3:05 PM
Unknown Object (File)
Sat, Apr 12, 5:29 AM
Unknown Object (File)
Wed, Mar 26, 9:42 AM
Unknown Object (File)
Mar 14 2025, 9:53 PM
Unknown Object (File)
Mar 14 2025, 10:57 AM
Unknown Object (File)
Mar 8 2025, 2:06 AM
Unknown Object (File)
Mar 8 2025, 2:05 AM
Unknown Object (File)
Mar 8 2025, 2:05 AM
View All 47 Files
Subscribers
ashoat

Details

Reviewers
varun
ginsu
will
tomek
Summary

Update updateRelationshipInputValidator to support both traditional and farcaster requests.

Changes will still need to be made within responder to handle farcaster requests, this just ensures that validation won't fail.

Depends on D11603

Test Plan

Tested implicitly by traditional/farcaster requests later in the stack. Could also add unit tests.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
8 lines

Diff 38960

View Options

keyserver/src/responders/relationship-responders.js

Show All 12 Lines
import ReportHandler from './report-handler.react.js'; import ReportHandler from './report-handler.react.js';
import RequestResponseHandler from './request-response-handler.react.js'; import RequestResponseHandler from './request-response-handler.react.js';
import UpdateHandler from './update-handler.react.js'; import UpdateHandler from './update-handler.react.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js'; import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js';
import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js';
import type { InitialNotifMessageOptions } from '../shared/crypto-utils.js';
import { import {
pingFrequency, pingFrequency,
serverRequestSocketTimeout, serverRequestSocketTimeout,
clientRequestVisualTimeout, clientRequestVisualTimeout,
clientRequestSocketTimeout, clientRequestSocketTimeout,
} from '../shared/timeouts.js'; } from '../shared/timeouts.js';
import { logInActionSources } from '../types/account-types.js'; import { logInActionSources } from '../types/account-types.js';
import type { CompressedData } from '../types/compression-types.js'; import type { CompressedData } from '../types/compression-types.js';
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Linestype Props = {
+lastCommunicatedPlatformDetails: ?PlatformDetails, +lastCommunicatedPlatformDetails: ?PlatformDetails,
+decompressSocketMessage: CompressedData => string, +decompressSocketMessage: CompressedData => string,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs // async functions that hit server APIs
+socketCrashLoopRecovery?: () => Promise<void>, +socketCrashLoopRecovery?: () => Promise<void>,
// keyserver olm sessions specific props // keyserver olm sessions specific props
+getInitialNotificationsEncryptedMessage?: () => Promise<string>, +getInitialNotificationsEncryptedMessage?: (
options?: ?InitialNotifMessageOptions,
) => Promise<string>,
}; };
type State = { type State = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
}; };
class Socket extends React.PureComponent<Props, State> { class Socket extends React.PureComponent<Props, State> {
state: State = { state: State = {
inflightRequests: null, inflightRequests: null,
}; };
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines