Page MenuHomePhabricator
Differential D11637

Implement JSI getter and setter for siwe backup secrets
ClosedPublic
Actions

Authored by marcin on Apr 11 2024, 9:10 AM.
Tags
None
Referenced Files
F3406049: D11637.diff
Wed, Dec 4, 12:25 AM
Unknown Object (File)
Nov 3 2024, 5:56 AM
Unknown Object (File)
Oct 31 2024, 9:39 PM
Unknown Object (File)
Oct 30 2024, 1:37 PM
Unknown Object (File)
Oct 12 2024, 5:49 PM
Unknown Object (File)
Oct 12 2024, 5:49 PM
Unknown Object (File)
Oct 12 2024, 5:49 PM
Unknown Object (File)
Oct 12 2024, 5:49 PM
View All 54 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
atul
Commits
rCOMM311dd775e343: Implement JSI getter and setter for siwe backup secrets
Summary

This diff implements JSI methods to set and get backup secrets into and from SQLite.

Test Plan

Call those functions in JS code and log results.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Apr 11 2024, 9:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 11 2024, 9:10 AM
marcin added a parent revision: D11636: Implement screen to create backup mesage and its signature.Apr 11 2024, 9:11 AM
Harbormaster completed remote builds in B28175: Diff 39062.Apr 11 2024, 9:34 AM
marcin requested review of this revision.Apr 11 2024, 9:34 AM
marcin added a child revision: D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.Apr 11 2024, 9:36 AM
atul accepted this revision.Apr 11 2024, 6:42 PM

Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)

This revision is now accepted and ready to land.Apr 11 2024, 6:42 PM
marcin added a comment.Apr 15 2024, 4:09 AM
In D11637#334446, @atul wrote:

Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)

No - CommCoreModule.{h, cpp} are not compiled to WASM.

marcin updated this revision to Diff 39406.Apr 23 2024, 6:06 AM

rebase before landing

Harbormaster completed remote builds in B28410: Diff 39406.Apr 23 2024, 6:25 AM
Closed by commit rCOMM311dd775e343: Implement JSI getter and setter for siwe backup secrets (authored by marcin). · Explain WhyApr 23 2024, 6:54 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM311dd775e343: Implement JSI getter and setter for siwe backup secrets.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
4 lines
77 lines
_generated/
schema/
7 lines

Diff 39406

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...