Page MenuHomePhabricator
Differential D11723

[SQLite] add queries to decrypted messages table
ClosedPublic
Actions

Authored by kamil on Mon, Apr 22, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 12, 1:11 AM
Unknown Object (File)
Fri, May 10, 12:53 AM
Unknown Object (File)
Mon, May 6, 9:11 PM
Unknown Object (File)
Fri, May 3, 5:00 PM
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMMd869a28e8c7d: [SQLite] add queries to decrypted messages table
Summary

API to:

  • add decrypted messages
  • get all messages (for now this is only needed method)
  • remove

Depends on D11722

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
publish-receiver
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mon, Apr 22, 4:21 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 22, 4:21 PM
Harbormaster completed remote builds in B28380: Diff 39374.Mon, Apr 22, 4:37 PM
kamil added a child revision: D11724: [SQLite/web] implement received message to device API.Mon, Apr 22, 4:49 PM
kamil published this revision for review.Tue, Apr 23, 6:39 AM
marcin added inline comments.Wed, Apr 24, 3:39 AM
lib/types/sqlite-types.js
7

Can we force it to confirm to a limited set of strings here?

marcin added inline comments.Wed, Apr 24, 4:13 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2172

Can we simplify this query to SELECT * FROM?

kamil added inline comments.Thu, Apr 25, 5:33 AM
lib/types/sqlite-types.js
7

I'll add a diff with definition and then update the type here

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2172

That will also query id field (see D11722) and we don't want that

marcin accepted this revision.Fri, Apr 26, 7:14 AM
This revision is now accepted and ready to land.Fri, Apr 26, 7:14 AM
Closed by commit rCOMMd869a28e8c7d: [SQLite] add queries to decrypted messages table (authored by kamil). · Explain WhyMon, Apr 29, 2:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd869a28e8c7d: [SQLite] add queries to decrypted messages table.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines
native/
cpp/
CommonCpp/
DatabaseManagers/
7 lines
6 lines
35 lines
entities/
34 lines
web/
cpp/
18 lines
shared-worker/
_generated/
queries/
77 lines
types/
5 lines

Diff 39374

View Options

lib/types/sqlite-types.js

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/ReceivedMessageToDevice.h

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm-query-executor.js

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/received-messages-to-device-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...