Paths

Table of Contentst

Differential D11723

[SQLite] add queries to decrypted messages table
ClosedPublic
Actions

Authored by kamil on Apr 22 2024, 4:21 PM.

Tags

None

Referenced Files

	F3340502: D11723.diff
	Thu, Nov 21, 9:55 PM

	Unknown Object (File)
	Tue, Nov 12, 8:43 AM

	Unknown Object (File)
	Wed, Nov 6, 4:41 AM

	Unknown Object (File)
	Oct 16 2024, 11:02 AM

	Unknown Object (File)
	Oct 14 2024, 4:58 PM

	Unknown Object (File)
	Oct 14 2024, 4:57 PM

	Unknown Object (File)
	Oct 14 2024, 4:57 PM

	Unknown Object (File)
	Oct 13 2024, 11:36 AM

View All 38 Files

Subscribers

Details

Reviewers

tomek
marcin

Commits

rCOMMd869a28e8c7d: [SQLite] add queries to decrypted messages table

Summary

API to:

add decrypted messages
get all messages (for now this is only needed method)
remove

Depends on D11722

Test Plan

Run tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 22 2024, 4:21 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2024, 4:21 PM

Harbormaster completed remote builds in B28380: Diff 39374.Apr 22 2024, 4:37 PM

kamil added a child revision: D11724: [SQLite/web] implement received message to device API.Apr 22 2024, 4:49 PM

kamil published this revision for review.Apr 23 2024, 6:39 AM

marcin added inline comments.Apr 24 2024, 3:39 AM

lib/types/sqlite-types.js
7 ↗	(On Diff #39374)	Can we force it to confirm to a limited set of strings here?

marcin added inline comments.Apr 24 2024, 4:13 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2172 ↗	(On Diff #39374)	Can we simplify this query to `SELECT * FROM`?

kamil added inline comments.Apr 25 2024, 5:33 AM

lib/types/sqlite-types.js
7 ↗	(On Diff #39374)	I'll add a diff with definition and then update the type here
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2172 ↗	(On Diff #39374)	That will also query `id` field (see D11722) and we don't want that

marcin accepted this revision.Apr 26 2024, 7:14 AM

This revision is now accepted and ready to land.Apr 26 2024, 7:14 AM

Closed by commit rCOMMd869a28e8c7d: [SQLite] add queries to decrypted messages table (authored by kamil). · Explain WhyApr 29 2024, 2:10 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd869a28e8c7d: [SQLite] add queries to decrypted messages table.

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

8 lines

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

7 lines

SQLiteQueryExecutor.h

6 lines

SQLiteQueryExecutor.cpp

35 lines

entities/

ReceivedMessageToDevice.h

34 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

18 lines

shared-worker/

_generated/

comm-query-executor.js

comm_query_executor.wasm

queries/

received-messages-to-device-queries.test.js

77 lines

types/

sqlite-query-executor.js

5 lines

Diff 39624

lib/types/sqlite-types.js

Loading...

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/DatabaseManagers/entities/ReceivedMessageToDevice.h

Loading...

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...

web/shared-worker/_generated/comm-query-executor.js

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/received-messages-to-device-queries.test.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...