[web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`
ClosedPublic
Actions

Authored by atul on May 9 2024, 2:08 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM9789033fdcb4: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`

Summary

Part of replacing threadInChatList with useThread[s]InChatList hooks, which in turn is part of replacing threadHasPermission with the useThreadHasPermission hook.

Depends on D11950

Test Plan

flow + close reading

Add log statements to SidebarsModal on web and ensure that threadInChatList and useThreadsInChatList return same results.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 9 2024, 2:08 PM

Harbormaster completed remote builds in B28825: Diff 40044.May 9 2024, 2:25 PM

atul requested review of this revision.May 9 2024, 2:25 PM

ashoat accepted this revision.May 9 2024, 5:09 PM

This revision is now accepted and ready to land.May 9 2024, 5:09 PM

atul added a child revision: D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.May 9 2024, 5:58 PM

resolve merge conflicts

atul edited the test plan for this revision. (Show Details)May 14 2024, 7:10 PM

Harbormaster completed remote builds in B28918: Diff 40191.May 14 2024, 7:25 PM

atul edited the test plan for this revision. (Show Details)May 15 2024, 11:25 AM

Closed by commit rCOMM9789033fdcb4: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal` (authored by atul). · Explain WhyMay 15 2024, 11:40 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9789033fdcb4: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

sidebars/

sidebars-modal.react.js

21 lines

Diff 40244

View Options

web/modals/threads/sidebars/sidebars-modal.react.js

[web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`ClosedPublicActions