Page MenuHomePhabricator
Differential D11913

[lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`
ClosedPublic
Actions

Authored by atul on Mon, May 6, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 6:52 PM
Unknown Object (File)
Thu, May 23, 1:48 PM
Unknown Object (File)
Thu, May 23, 3:39 AM
Unknown Object (File)
Sat, May 18, 8:13 AM
Unknown Object (File)
Fri, May 17, 9:08 PM
Unknown Object (File)
Fri, May 17, 2:58 PM
F1756564: b6778a.png
Tue, May 14, 10:32 AM
F1756563: d3e5af.png
Tue, May 14, 10:32 AM
View All 18 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
will
Commits
rCOMM50421aba1c22: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`
Summary

Similar to getAvailableThreadMemberActions but consumes useThreadHasPermission instead of threadHasPermission.

Also consume hook in web/Member to show usage.

Test Plan

flow + close reading for now

Logged return value of getAvailableThreadMemberActions before and useAvailableThreadMemberActions after to ensure that they remained the same.

Before:

d3e5af.png (406×480 px, 40 KB)

After:

b6778a.png (300×780 px, 34 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mon, May 6, 12:23 PM
atul updated this revision to Diff 39871.Mon, May 6, 12:36 PM

memoize

Harbormaster completed remote builds in B28715: Diff 39869.Mon, May 6, 12:42 PM
Harbormaster completed remote builds in B28717: Diff 39871.Mon, May 6, 12:52 PM
atul requested review of this revision.Mon, May 6, 12:52 PM
ashoat added a comment.Mon, May 6, 1:02 PM

Will getAvailableThreadMemberActions be deprecated at the end of this stack? If not, I think it would be good to factor out the logic instead of copy-pasting

lib/shared/thread-utils.js
1696 ↗(On Diff #39871)

Nit

ashoat accepted this revision.Mon, May 6, 1:02 PM
This revision is now accepted and ready to land.Mon, May 6, 1:02 PM
atul added a child revision: D11914: [native] Consume `useAvailableThreadMemberActions` in `native/ThreadSettingsMember`.Mon, May 6, 1:13 PM
atul updated this revision to Diff 40168.Tue, May 14, 9:13 AM

rebase before addressing feedback

atul updated this revision to Diff 40169.Tue, May 14, 9:18 AM

address feedback

Harbormaster completed remote builds in B28903: Diff 40168.Tue, May 14, 9:29 AM
Harbormaster completed remote builds in B28904: Diff 40169.Tue, May 14, 9:35 AM
atul edited the test plan for this revision. (Show Details)Tue, May 14, 10:32 AM
atul edited the test plan for this revision. (Show Details)
Closed by commit rCOMM50421aba1c22: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member` (authored by atul). · Explain WhyTue, May 14, 10:33 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM50421aba1c22: [lib] Introduce `useAvailableThreadMemberActions` and consume in `web/Member`.
atul added a comment.Tue, May 14, 10:46 AM
In D11913#341032, @ashoat wrote:

Will getAvailableThreadMemberActions be deprecated at the end of this stack? If not, I think it would be good to factor out the logic instead of copy-pasting

Gets deleted in D11914

Revision Contents
Changeset List

PathSize
lib/
shared/
43 lines
web/
modals/
threads/
members/
11 lines

Diff 40175

View Options

lib/shared/thread-utils.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...