Page MenuHomePhabricator

[lib] Introduce `useOnScreenEntryEditableThreadInfos`
ClosedPublic

Authored by atul on May 7 2024, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 7:39 PM
Unknown Object (File)
Thu, Oct 24, 6:31 PM
Unknown Object (File)
Thu, Oct 24, 4:32 PM
Unknown Object (File)
Tue, Oct 22, 1:15 PM
Unknown Object (File)
Tue, Oct 22, 9:03 AM
Unknown Object (File)
Tue, Oct 22, 8:34 AM
Unknown Object (File)
Mon, Oct 14, 1:11 AM
Unknown Object (File)
Sep 26 2024, 3:00 AM
Subscribers
None

Details

Summary

Replace onScreenEntryEditableThreadInfos with hook which consumes useThreadsWithPermission introduced in D11924.


Depends on D11924

Test Plan

flow + close reading for now

Checked ThreadPickerModal on web (skipped native, but assuming everything is the same since lib) and ensured that threads appeared as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.May 7 2024, 10:38 AM

As an aside, it might be nice to separate hooks from thread-utils and put them in eg thread-hooks file? Maybe even move permission-related utilities to something like thread-permission-utils?

thread-utils is getting a little unwieldy at least for me, and have noticed that IDE sometimes struggles with eg format on save due to the size.

On surface seems like 2 min task to separate hooks, but in practice it'd probably be a pain because of dependency cycles so prob not worth

Yeah thread-utils is def large and unwieldy. I wonder if there's a tool or IDE that can help with refactoring. You'd def be welcome to do any tidying up that you want

This revision is now accepted and ready to land.May 7 2024, 6:27 PM
This revision was landed with ongoing or failed builds.May 14 2024, 6:16 PM
This revision was automatically updated to reflect the committed changes.