[lib] Introduce `useOnScreenEntryEditableThreadInfos`
ClosedPublic
Actions

Authored by atul on May 7 2024, 10:22 AM.

Details

Reviewers

ashoat
ginsu
tomek
varun
will

Commits

rCOMM0ab6a315ac2d: [lib] Introduce `useOnScreenEntryEditableThreadInfos`

Summary

Replace onScreenEntryEditableThreadInfos with hook which consumes useThreadsWithPermission introduced in D11924.

Depends on D11924

Test Plan

flow + close reading for now

Checked ThreadPickerModal on web (skipped native, but assuming everything is the same since lib) and ensured that threads appeared as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 7 2024, 10:22 AM

atul edited the summary of this revision. (Show Details)May 7 2024, 10:27 AM

Harbormaster completed remote builds in B28741: Diff 39900.May 7 2024, 10:38 AM

atul requested review of this revision.May 7 2024, 10:38 AM

As an aside, it might be nice to separate hooks from thread-utils and put them in eg thread-hooks file? Maybe even move permission-related utilities to something like thread-permission-utils?

thread-utils is getting a little unwieldy at least for me, and have noticed that IDE sometimes struggles with eg format on save due to the size.

On surface seems like 2 min task to separate hooks, but in practice it'd probably be a pain because of dependency cycles so prob not worth

Yeah thread-utils is def large and unwieldy. I wonder if there's a tool or IDE that can help with refactoring. You'd def be welcome to do any tidying up that you want

This revision is now accepted and ready to land.May 7 2024, 6:27 PM

atul added a child revision: D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.May 8 2024, 6:41 PM

atul edited the test plan for this revision. (Show Details)May 14 2024, 6:15 PM

land

This revision was landed with ongoing or failed builds.May 14 2024, 6:16 PM

Closed by commit rCOMM0ab6a315ac2d: [lib] Introduce `useOnScreenEntryEditableThreadInfos` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0ab6a315ac2d: [lib] Introduce `useOnScreenEntryEditableThreadInfos`.

Harbormaster completed remote builds in B28916: Diff 40188.May 14 2024, 6:33 PM