Page MenuHomePhabricator
Differential D11915

[lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`
ClosedPublic
Actions

Authored by atul on Mon, May 6, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 2:21 PM
Unknown Object (File)
Fri, May 17, 8:44 AM
Unknown Object (File)
Wed, May 15, 2:08 AM
Unknown Object (File)
Sat, May 11, 10:11 PM
Unknown Object (File)
Sat, May 11, 6:02 PM
Unknown Object (File)
Thu, May 9, 8:33 PM
Unknown Object (File)
Mon, May 6, 3:28 PM
Unknown Object (File)
Mon, May 6, 3:24 PM
View All 9 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
will
Commits
rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`
Summary

Similar to rest of diff, we want to replace usages of threadHasPermission with useThreadHasPermission.

Depends on D11914

Test Plan

flow and close reading for now.

Logged return value of threadHasPermission and useThreadHasPermission in ThreadListProvider and ensured that they remained the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mon, May 6, 1:39 PM
atul published this revision for review.Mon, May 6, 1:51 PM
Harbormaster completed remote builds in B28719: Diff 39873.Mon, May 6, 1:58 PM
atul added a child revision: D11916: [native] Consume `useThreadInChatList` in `native/ThreadSettings`.Mon, May 6, 2:11 PM
ashoat accepted this revision.Mon, May 6, 2:12 PM
ashoat added inline comments.
lib/shared/thread-utils.js
209–212 ↗(On Diff #39873)

What's the point of memoizing a boolean?

This revision is now accepted and ready to land.Mon, May 6, 2:12 PM
atul added inline comments.Mon, May 6, 2:15 PM
lib/shared/thread-utils.js
209–212 ↗(On Diff #39873)

Yeah there's no point, I'll revert

atul updated this revision to Diff 40178.Tue, May 14, 11:15 AM

address feedback (remove memoization of boolean value)

atul edited the test plan for this revision. (Show Details)Tue, May 14, 11:17 AM
Harbormaster completed remote builds in B28909: Diff 40178.Tue, May 14, 11:32 AM
Closed by commit rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider` (authored by atul). · Explain WhyTue, May 14, 1:10 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`.

Revision Contents
Changeset List

PathSize
lib/
shared/
9 lines
web/
chat/
7 lines

Diff 40181

View Options

lib/shared/thread-utils.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...