Page MenuHomePhabricator
Differential D11915

[lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`
ClosedPublic
Actions

Authored by atul on May 6 2024, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 2:21 AM
Unknown Object (File)
Jan 24 2025, 8:18 PM
Unknown Object (File)
Jan 24 2025, 5:59 AM
Unknown Object (File)
Jan 24 2025, 5:59 AM
Unknown Object (File)
Jan 24 2025, 5:59 AM
Unknown Object (File)
Jan 24 2025, 5:58 AM
Unknown Object (File)
Dec 23 2024, 8:42 AM
Unknown Object (File)
Dec 22 2024, 8:28 PM
View All 74 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
will
Commits
rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`
Summary

Similar to rest of diff, we want to replace usages of threadHasPermission with useThreadHasPermission.

Depends on D11914

Test Plan

flow and close reading for now.

Logged return value of threadHasPermission and useThreadHasPermission in ThreadListProvider and ensured that they remained the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 6 2024, 1:39 PM
atul published this revision for review.May 6 2024, 1:51 PM
Harbormaster completed remote builds in B28719: Diff 39873.May 6 2024, 1:58 PM
atul added a child revision: D11916: [native] Consume `useThreadInChatList` in `native/ThreadSettings`.May 6 2024, 2:11 PM
ashoat accepted this revision.May 6 2024, 2:12 PM
ashoat added inline comments.
lib/shared/thread-utils.js
209–212 ↗(On Diff #39873)

What's the point of memoizing a boolean?

This revision is now accepted and ready to land.May 6 2024, 2:12 PM
atul added inline comments.May 6 2024, 2:15 PM
lib/shared/thread-utils.js
209–212 ↗(On Diff #39873)

Yeah there's no point, I'll revert

atul updated this revision to Diff 40178.May 14 2024, 11:15 AM

address feedback (remove memoization of boolean value)

atul edited the test plan for this revision. (Show Details)May 14 2024, 11:17 AM
Harbormaster completed remote builds in B28909: Diff 40178.May 14 2024, 11:32 AM
Closed by commit rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider` (authored by atul). · Explain WhyMay 14 2024, 1:10 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM10778f439a3f: [lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`.

Revision Contents
Changeset List

PathSize
lib/
shared/
9 lines
web/
chat/
7 lines

Diff 40181

View Options

lib/shared/thread-utils.js

locals { locals {
identity_service_image_tag = local.is_staging ? "0.37" : "0.37" identity_service_image_tag = local.is_staging ? "0.38" : "0.37"
identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}" identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
identity_service_container_name = "identity-server" identity_service_container_name = "identity-server"
# Port that the container is listening on # Port that the container is listening on
identity_service_container_grpc_port = 50054 identity_service_container_grpc_port = 50054
identity_sc_port_name = "identity-service-ecs-grpc" identity_sc_port_name = "identity-service-ecs-grpc"
identity_sc_dns_name = "identity-service" identity_sc_dns_name = "identity-service"
▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines
View Options

web/chat/thread-list-provider.js

locals { locals {
identity_service_image_tag = local.is_staging ? "0.37" : "0.37" identity_service_image_tag = local.is_staging ? "0.38" : "0.37"
identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}" identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
identity_service_container_name = "identity-server" identity_service_container_name = "identity-server"
# Port that the container is listening on # Port that the container is listening on
identity_service_container_grpc_port = 50054 identity_service_container_grpc_port = 50054
identity_sc_port_name = "identity-service-ecs-grpc" identity_sc_port_name = "identity-service-ecs-grpc"
identity_sc_dns_name = "identity-service" identity_sc_dns_name = "identity-service"
▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines