Page MenuHomePhabricator

[lib] Introduce `useThreadInChatList` and consume in `web/ThreadListProvider`
ClosedPublic

Authored by atul on May 6 2024, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 3:54 AM
Unknown Object (File)
Tue, Nov 26, 1:34 AM
Unknown Object (File)
Thu, Nov 21, 2:21 AM
Unknown Object (File)
Thu, Nov 21, 2:21 AM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 7:17 PM
Unknown Object (File)
Oct 26 2024, 7:57 PM
Unknown Object (File)
Oct 22 2024, 1:15 PM
Subscribers
None

Details

Summary

Similar to rest of diff, we want to replace usages of threadHasPermission with useThreadHasPermission.


Depends on D11914

Test Plan

flow and close reading for now.

Logged return value of threadHasPermission and useThreadHasPermission in ThreadListProvider and ensured that they remained the same.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D11915 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.May 6 2024, 1:51 PM
ashoat added inline comments.
lib/shared/thread-utils.js
209–212 ↗(On Diff #39873)

What's the point of memoizing a boolean?

This revision is now accepted and ready to land.May 6 2024, 2:12 PM
lib/shared/thread-utils.js
209–212 ↗(On Diff #39873)

Yeah there's no point, I'll revert

address feedback (remove memoization of boolean value)