Similar to rest of stack, we want to replace usages of threadHasPermission with useThreadHasPermission which we're doing indirectly when we replace threadInChatList with useThreadInChatList.
Depends on D11915
Paths
| Differential D11916 Authored by atul on May 6 2024, 2:11 PM.
Details Summary Similar to rest of stack, we want to replace usages of threadHasPermission with useThreadHasPermission which we're doing indirectly when we replace threadInChatList with useThreadInChatList. Depends on D11915 Test Plan flow + close reading for now Logged value of isThreadInChatList and ensured it was same before/after change.
Diff Detail
Event TimelineHarbormaster completed remote builds in B28720: Diff 39874.May 6 2024, 2:29 PM2024-05-06 14:29:24 (UTC-7) Comment Actions
Sounds risky for a change that changes the flow.
This revision is now accepted and ready to land.May 7 2024, 1:53 AM2024-05-07 01:53:42 (UTC-7) atul edited the test plan for this revision. (Show Details)May 14 2024, 1:15 PM2024-05-14 13:15:58 (UTC-7) This revision was landed with ongoing or failed builds.May 14 2024, 1:26 PM2024-05-14 13:26:53 (UTC-7) Closed by commit rCOMMd90270ac68f8: [native] Consume `useThreadInChatList` in `native/ThreadSettings` (authored by atul). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B28912: Diff 40182.May 14 2024, 1:35 PM2024-05-14 13:35:33 (UTC-7)
Revision Contents
Diff 40183 lib/shared/thread-utils.js
native/chat/settings/thread-settings.react.js
web/chat/thread-list-provider.js
|