Page MenuHomePhabricator
Differential D11916

[native] Consume `useThreadInChatList` in `native/ThreadSettings`
ClosedPublic
Actions

Authored by atul on May 6 2024, 2:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 2:21 AM
Unknown Object (File)
Thu, Nov 21, 2:21 AM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 7:17 PM
Unknown Object (File)
Oct 22 2024, 1:15 PM
Unknown Object (File)
Oct 22 2024, 9:03 AM
Unknown Object (File)
Oct 22 2024, 8:34 AM
Unknown Object (File)
Oct 7 2024, 5:55 PM
View All 54 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
will
Commits
rCOMMd90270ac68f8: [native] Consume `useThreadInChatList` in `native/ThreadSettings`
Summary

Similar to rest of stack, we want to replace usages of threadHasPermission with useThreadHasPermission which we're doing indirectly when we replace threadInChatList with useThreadInChatList.

Depends on D11915

Test Plan

flow + close reading for now

Logged value of isThreadInChatList and ensured it was same before/after change.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 6 2024, 2:11 PM
atul published this revision for review.May 6 2024, 2:16 PM
Harbormaster completed remote builds in B28720: Diff 39874.May 6 2024, 2:29 PM
tomek accepted this revision.May 7 2024, 1:53 AM

flow + close reading for now

Sounds risky for a change that changes the flow.

native/chat/settings/thread-settings.react.js
1166

I find these names a bit confusing - they don't indicate that they are boolean flags. This might be expensive, but I think it would be better to put is somewhere inside them.

This revision is now accepted and ready to land.May 7 2024, 1:53 AM
atul added a child revision: D11924: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s.May 7 2024, 9:21 AM
atul edited the test plan for this revision. (Show Details)May 14 2024, 1:15 PM
atul updated this revision to Diff 40182.May 14 2024, 1:17 PM

address feedback (useThreadInChatList -> useIsThreadInChatList)

This revision was landed with ongoing or failed builds.May 14 2024, 1:26 PM
Closed by commit rCOMMd90270ac68f8: [native] Consume `useThreadInChatList` in `native/ThreadSettings` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd90270ac68f8: [native] Consume `useThreadInChatList` in `native/ThreadSettings`.
Harbormaster completed remote builds in B28912: Diff 40182.May 14 2024, 1:35 PM

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
7 lines

Diff 39874

View Options

native/chat/settings/thread-settings.react.js

Loading...