Differential D11981

[lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`
ClosedPublic
Actions

Authored by atul on May 9 2024, 5:58 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun
will

Commits

rCOMM9a0a2d05b565: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`

Summary

Similar to rest of stack, but for useWatchThread.

Depends on D11980

Test Plan

flow + close reading

Set log statements in useWatchThread and ensured that values before and after were identical.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 9 2024, 5:58 PM

atul published this revision for review.May 9 2024, 6:01 PM

Harbormaster completed remote builds in B28826: Diff 40045.May 9 2024, 6:16 PM

tomek accepted this revision.May 10 2024, 3:48 AM

tomek added inline comments.

lib/shared/thread-utils.js
1299–1318 ↗	(On Diff #40045)	We usually prefer to call hooks top level, without modifying their result

This revision is now accepted and ready to land.May 10 2024, 3:48 AM

resolve merge conflicts

fix

Harbormaster failed remote builds in B28919: Diff 40192!May 14 2024, 7:21 PM

Harbormaster completed remote builds in B28921: Diff 40194.May 14 2024, 7:36 PM

atul edited the test plan for this revision. (Show Details)May 15 2024, 11:37 AM

Closed by commit rCOMM9a0a2d05b565: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread` (authored by atul). · Explain WhyMay 15 2024, 11:40 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9a0a2d05b565: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

8 lines

Diff 40245

View Options

lib/shared/thread-utils.js

[lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`ClosedPublicActions