Page MenuHomePhabricator

[lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`
ClosedPublic

Authored by atul on May 9 2024, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 5:32 PM
Unknown Object (File)
Tue, Oct 22, 1:15 PM
Unknown Object (File)
Tue, Oct 22, 9:04 AM
Unknown Object (File)
Tue, Oct 22, 8:34 AM
Unknown Object (File)
Sun, Oct 6, 10:50 PM
Unknown Object (File)
Sep 26 2024, 3:00 AM
Unknown Object (File)
Sep 26 2024, 3:00 AM
Unknown Object (File)
Sep 26 2024, 3:00 AM
Subscribers
None

Details

Summary

Similar to rest of stack, but for useWatchThread.


Depends on D11980

Test Plan

flow + close reading

Set log statements in useWatchThread and ensured that values before and after were identical.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.May 9 2024, 6:01 PM
tomek added inline comments.
lib/shared/thread-utils.js
1299–1318 ↗(On Diff #40045)

We usually prefer to call hooks top level, without modifying their result

This revision is now accepted and ready to land.May 10 2024, 3:48 AM