Page MenuHomePhabricator

[SQLite] add query to mark outbound P2P message as sent
ClosedPublic

Authored by kamil on May 16 2024, 5:28 AM.
Tags
None
Referenced Files
F2798202: D12071.diff
Mon, Sep 23, 4:18 AM
Unknown Object (File)
Wed, Sep 4, 4:18 AM
Unknown Object (File)
Tue, Aug 27, 11:57 AM
Unknown Object (File)
Tue, Aug 27, 4:53 AM
Unknown Object (File)
Aug 6 2024, 12:23 PM
Unknown Object (File)
Aug 6 2024, 12:22 PM
Unknown Object (File)
Aug 6 2024, 11:00 AM
Unknown Object (File)
Jul 15 2024, 7:26 AM
Subscribers

Details

Summary

We want to mark message as sent to avoid sending this again. Attempt to send message should happen only for encrypted messages, and even if marking as sent fails this is not a problem - this message will be sent but message will be discarded due to not being able to decrypt the same message twice.

Using hardcoded constants in code - for later usage on the JS side I'll introduce type to make it safer.

Depends on D12070

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 17 2024, 3:22 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2222–2224 ↗(On Diff #40284)

Please use SQLiteDataConverters.h

2227–2232 ↗(On Diff #40284)

You can remove those lines - SQLiteStatementWrapper destructor does it automatically.

This revision is now accepted and ready to land.May 23 2024, 8:42 AM