Page MenuHomePhabricator
Differential D12253

[sqlite] implement logic to get message store logic from SQLite
ClosedPublic
Actions

Authored by will on Thu, May 30, 2:13 PM.
Tags
None
Referenced Files
F2138747: D12253.diff
Sat, Jun 29, 12:03 AM
Unknown Object (File)
Tue, Jun 18, 12:16 AM
Unknown Object (File)
Tue, Jun 18, 12:16 AM
Unknown Object (File)
Tue, Jun 18, 12:16 AM
Unknown Object (File)
Fri, Jun 14, 6:50 PM
Unknown Object (File)
Thu, Jun 13, 1:33 AM
Unknown Object (File)
Thu, Jun 13, 12:20 AM
Unknown Object (File)
Mon, Jun 10, 4:25 AM
View All 20 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
ginsu
Commits
rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite
Summary

Selects message store local data in C++ from SQLite

Depends on D12249

Test Plan

Logged the result and verified with SQLite table. Tested further in stack.

Diff Detail

Repository
rCOMM Comm
Branch
sqlite/localmessagestore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Thu, May 30, 2:13 PM
Herald added a subscriber: ashoat. · View Herald TranscriptThu, May 30, 2:13 PM
Harbormaster completed remote builds in B29321: Diff 40796.Thu, May 30, 2:30 PM
will requested review of this revision.Thu, May 30, 2:30 PM
tomek accepted this revision.Mon, Jun 3, 4:42 AM

Depends on https://phab.comm.dev/D12249

Setting a dependency on the URL doesn't work - we have to use just the diff id D12249

This revision is now accepted and ready to land.Mon, Jun 3, 4:42 AM
will edited the summary of this revision. (Show Details)Mon, Jun 3, 4:44 AM
will added a parent revision: D12249: [sqlite] Implement C++ message store local ops.
In D12253#349092, @tomek wrote:

Depends on https://phab.comm.dev/D12249

Setting a dependency on the URL doesn't work - we have to use just the diff id D12249

Thanks for catching that

ginsu added a child revision: D12357: [web] handle message store local ops types in processMessageStoreOperations.Fri, Jun 7, 4:50 PM
will updated this revision to Diff 41161.Mon, Jun 10, 5:16 AM

rebase before landing

will updated this revision to Diff 41162.Mon, Jun 10, 5:29 AM

fix prior rebase

Harbormaster completed remote builds in B29573: Diff 41161.Mon, Jun 10, 5:33 AM
Harbormaster completed remote builds in B29574: Diff 41162.Mon, Jun 10, 5:46 AM
Closed by commit rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite (authored by will). · Explain WhyMon, Jun 10, 5:57 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM311602b156e7: [sqlite] implement logic to get message store logic from SQLite.

Revision Contents
Changeset List

PathSize
lib/
reducers/
1 line
types/
4 lines
native/
cpp/
CommonCpp/
NativeModules/
15 lines
PersistentStorageUtilities/
DataStores/
19 lines
web/
shared-worker/
utils/
1 line
worker/
2 lines

Diff 41162

View Options

lib/reducers/message-reducer.test.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageStore.cpp

Loading...
View Options

web/shared-worker/utils/store.js

Loading...
View Options

web/shared-worker/worker/process-operations.js

Loading...