[native_rust_library] Write state version as build-time constant
ClosedPublic
Actions

Authored by bartek on Jun 3 2024, 4:32 AM.

Details

Reviewers

varun
marcin

Commits

rCOMMd9300c1b7ff8: [native_rust_library] Write state version as build-time constant

Summary

We're going to pass state version in gRPC metadata - this updates native_rust_library build.rs to scrap it
from native/redux/persist.js.
Some context in ENG-8279.

Test Plan

cd native_rust_library && cargo build --verbose. In IDE, added use crate::STATE_VERSION then used my IDE
to jump to definition. Found generated value matching the value from persist.js.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 3 2024, 4:32 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 3 2024, 4:32 AM

Harbormaster failed remote builds in B29354: Diff 40839!Jun 3 2024, 4:33 AM

bartek added a child revision: D12279: [grpc_clients] Add platform details metadata.Jun 3 2024, 5:36 AM

bartek published this revision for review.Jun 3 2024, 5:43 AM

Harbormaster completed remote builds in B29354: Diff 40839.Jun 3 2024, 8:29 AM

Can we add a code comment to persist.js explaining that this script parses the file, so that a dev doesn't eg. rename the constant or move it without being aware of this?