Page MenuHomePhabricator
Differential D12408

[web] remove ping component
ClosedPublic
Actions

Authored by varun on Jun 12 2024, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 13, 9:34 AM
Unknown Object (File)
Sun, Apr 13, 5:35 AM
Unknown Object (File)
Sat, Apr 12, 9:54 PM
Unknown Object (File)
Fri, Apr 11, 9:09 PM
Unknown Object (File)
Sat, Apr 5, 10:48 AM
Unknown Object (File)
Fri, Mar 28, 10:49 PM
Unknown Object (File)
Fri, Mar 28, 9:51 AM
Unknown Object (File)
Mar 23 2025, 8:53 AM
View All 62 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMc6d5f53a58a5: [web] remove ping component
Summary

we are now calling the identity service from MinVersionHandler on web, so there's no need for this ping component anymore. the point was to make sure that the identity client is callable via gRPC-web on prod, which is achieved now in MinVersionHandler.

Depends on D12407

Test Plan

made sure there were no references to IdentityPing left in code

Diff Detail

Repository
rCOMM Comm
Branch
webping (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
2 lines
components/

Diff 41251

View Options

web/app.react.js

// @flow // @flow
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { import {
getAvatarForUser, getAvatarForUser,
getRandomDefaultEmojiAvatar, getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js'; } from '../shared/avatar-utils.js';
import SearchIndex from '../shared/search-index.js';
import SentencePrefixSearchIndex from '../shared/sentence-prefix-search-index.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 145 Lines • ▼ Show 20 Lines
const isLoggedIn = (state: BaseAppState<>): boolean => const isLoggedIn = (state: BaseAppState<>): boolean =>
!!( !!(
state.currentUserInfo && state.currentUserInfo &&
!state.currentUserInfo.anonymous && !state.currentUserInfo.anonymous &&
state.dataLoaded state.dataLoaded
); );
const addUsersToSearchIndex = (
userInfos: UserInfos,
searchIndex: SearchIndex | SentencePrefixSearchIndex,
): void => {
for (const id in userInfos) {
const { username } = userInfos[id];
if (!username) {
continue;
}
searchIndex.addEntry(id, username);
}
};
const userStoreMentionSearchIndex: (
state: BaseAppState<>,
) => SentencePrefixSearchIndex = createSelector(
(state: BaseAppState<>) => state.userStore.userInfos,
(userInfos: UserInfos) => {
const searchIndex = new SentencePrefixSearchIndex();
addUsersToSearchIndex(userInfos, searchIndex);
return searchIndex;
},
);
const usersWithPersonalThreadSelector: ( const usersWithPersonalThreadSelector: (
state: BaseAppState<>, state: BaseAppState<>,
) => $ReadOnlySet<string> = createSelector( ) => $ReadOnlySet<string> = createSelector(
(state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id, (state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id,
(state: BaseAppState<>) => state.threadStore.threadInfos, (state: BaseAppState<>) => state.threadStore.threadInfos,
(viewerID: ?string, threadInfos: RawThreadInfos) => { (viewerID: ?string, threadInfos: RawThreadInfos) => {
const personalThreadMembers = new Set<string>(); const personalThreadMembers = new Set<string>();
Show All 30 Lines
); );
export { export {
userIDsToRelativeUserInfos, userIDsToRelativeUserInfos,
getRelativeMemberInfos, getRelativeMemberInfos,
relativeMemberInfoSelectorForMembersOfThread, relativeMemberInfoSelectorForMembersOfThread,
userInfoSelectorForPotentialMembers, userInfoSelectorForPotentialMembers,
isLoggedIn, isLoggedIn,
userStoreMentionSearchIndex,
usersWithPersonalThreadSelector, usersWithPersonalThreadSelector,
savedEmojiAvatarSelectorForCurrentUser, savedEmojiAvatarSelectorForCurrentUser,
}; };
View Options

web/components/identity-ping.react.js

// @flow // @flow
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { import {
getAvatarForUser, getAvatarForUser,
getRandomDefaultEmojiAvatar, getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js'; } from '../shared/avatar-utils.js';
import SearchIndex from '../shared/search-index.js';
import SentencePrefixSearchIndex from '../shared/sentence-prefix-search-index.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 145 Lines • ▼ Show 20 Lines
const isLoggedIn = (state: BaseAppState<>): boolean => const isLoggedIn = (state: BaseAppState<>): boolean =>
!!( !!(
state.currentUserInfo && state.currentUserInfo &&
!state.currentUserInfo.anonymous && !state.currentUserInfo.anonymous &&
state.dataLoaded state.dataLoaded
); );
const addUsersToSearchIndex = (
userInfos: UserInfos,
searchIndex: SearchIndex | SentencePrefixSearchIndex,
): void => {
for (const id in userInfos) {
const { username } = userInfos[id];
if (!username) {
continue;
}
searchIndex.addEntry(id, username);
}
};
const userStoreMentionSearchIndex: (
state: BaseAppState<>,
) => SentencePrefixSearchIndex = createSelector(
(state: BaseAppState<>) => state.userStore.userInfos,
(userInfos: UserInfos) => {
const searchIndex = new SentencePrefixSearchIndex();
addUsersToSearchIndex(userInfos, searchIndex);
return searchIndex;
},
);
const usersWithPersonalThreadSelector: ( const usersWithPersonalThreadSelector: (
state: BaseAppState<>, state: BaseAppState<>,
) => $ReadOnlySet<string> = createSelector( ) => $ReadOnlySet<string> = createSelector(
(state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id, (state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id,
(state: BaseAppState<>) => state.threadStore.threadInfos, (state: BaseAppState<>) => state.threadStore.threadInfos,
(viewerID: ?string, threadInfos: RawThreadInfos) => { (viewerID: ?string, threadInfos: RawThreadInfos) => {
const personalThreadMembers = new Set<string>(); const personalThreadMembers = new Set<string>();
Show All 30 Lines
); );
export { export {
userIDsToRelativeUserInfos, userIDsToRelativeUserInfos,
getRelativeMemberInfos, getRelativeMemberInfos,
relativeMemberInfoSelectorForMembersOfThread, relativeMemberInfoSelectorForMembersOfThread,
userInfoSelectorForPotentialMembers, userInfoSelectorForPotentialMembers,
isLoggedIn, isLoggedIn,
userStoreMentionSearchIndex,
usersWithPersonalThreadSelector, usersWithPersonalThreadSelector,
savedEmojiAvatarSelectorForCurrentUser, savedEmojiAvatarSelectorForCurrentUser,
}; };