Page MenuHomePhabricator

[lib] Join a thread from an invite link
ClosedPublic

Authored by tomek on Thu, Jun 13, 5:58 AM.
Tags
None
Referenced Files
F2180893: D12425.diff
Wed, Jul 3, 3:49 PM
Unknown Object (File)
Sun, Jun 30, 9:05 AM
Unknown Object (File)
Thu, Jun 27, 9:14 AM
Unknown Object (File)
Tue, Jun 25, 9:59 AM
Unknown Object (File)
Sun, Jun 23, 9:18 PM
Unknown Object (File)
Sat, Jun 22, 2:59 AM
Unknown Object (File)
Fri, Jun 21, 6:19 PM
Unknown Object (File)
Thu, Jun 20, 9:08 PM
Subscribers

Details

Summary

After joining a community, we check if a link is a thread link and join a thread if necessary.

https://linear.app/comm/issue/ENG-8250/join-a-thread-after-joining-a-community

Depends on D12424

Test Plan

Tested following cases:

  1. Accepting a community link when a user isn't a member of the community
  2. Accepting a thread link when a user isn't a member of the community
  3. Accepting a thread link when a user is a member of the community and isn't a member of the thread
  4. Clicking a community link when a user is a member of the community
  5. Clicking a thread link when a user is a member of the thread
  6. Clicking an invalid link
  7. Accepting a thread link when a user isn't a member of the community with a modification on the server side so that joining a thread fails. This results in joining the community and a modal with This invite link may be expired. Please try again with another invite link. message.

Diff Detail

Repository
rCOMM Comm
Branch
links
Lint
No Lint Coverage
Unit
No Test Coverage