[Tunnelbroker] implement APNs response types
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 5:29 AM.

Details

Reviewers

bartek
marcin

Commits

rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types

Summary

Types describing APNs responses, taken from Apple docs Handling notification responses from APNs.

Depends on D12612

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

apns-tb

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 28 2024, 5:29 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 5:30 AM

kamil added a child revision: D12614: [Tunnelbroker] implement sending APNs notif.Jun 28 2024, 5:37 AM

Harbormaster completed remote builds in B29992: Diff 41791.Jun 28 2024, 5:46 AM

kamil published this revision for review.Jun 28 2024, 6:31 AM

bartek accepted this revision.Jul 1 2024, 2:19 AM

bartek added inline comments.

services/tunnelbroker/src/notifs/apns/response.rs
4–6	Should we add a link to Apple docs here? The one mentioned in the diff description

This revision is now accepted and ready to land.Jul 1 2024, 2:19 AM

add link

Harbormaster completed remote builds in B30052: Diff 41883.Jul 2 2024, 6:15 AM

Closed by commit rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types (authored by kamil). · Explain WhyJul 2 2024, 8:35 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifs/

apns/

mod.rs

1 line

response.rs

114 lines

Diff 41791

View Options

services/tunnelbroker/src/notifs/apns/mod.rs