Page MenuHomePhabricator
Differential D12613

[Tunnelbroker] implement APNs response types
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 5:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 10:36 AM
Unknown Object (File)
Wed, Mar 12, 4:43 AM
Unknown Object (File)
Wed, Mar 12, 2:17 AM
Unknown Object (File)
Tue, Mar 11, 3:07 PM
Unknown Object (File)
Tue, Mar 11, 11:44 AM
Unknown Object (File)
Thu, Mar 6, 10:28 PM
Unknown Object (File)
Thu, Mar 6, 3:59 PM
Unknown Object (File)
Feb 21 2025, 3:49 PM
View All 93 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types
Summary

Types describing APNs responses, taken from Apple docs Handling notification responses from APNs.

Depends on D12612

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
land-apns
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 28 2024, 5:29 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 5:30 AM
kamil added a child revision: D12614: [Tunnelbroker] implement sending APNs notif.Jun 28 2024, 5:37 AM
Harbormaster completed remote builds in B29992: Diff 41791.Jun 28 2024, 5:46 AM
kamil published this revision for review.Jun 28 2024, 6:31 AM
bartek accepted this revision.Jul 1 2024, 2:19 AM
bartek added inline comments.
services/tunnelbroker/src/notifs/apns/response.rs
4–6 ↗(On Diff #41791)

Should we add a link to Apple docs here? The one mentioned in the diff description

This revision is now accepted and ready to land.Jul 1 2024, 2:19 AM
kamil updated this revision to Diff 41883.Jul 2 2024, 5:58 AM

add link

Harbormaster completed remote builds in B30052: Diff 41883.Jul 2 2024, 6:15 AM
Closed by commit rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types (authored by kamil). · Explain WhyJul 2 2024, 8:35 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
apns/
1 line
116 lines

Diff 41883

View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/notifs/apns/response.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines