Page MenuHomePhabricator
Differential D12613

[Tunnelbroker] implement APNs response types
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 5:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 2:55 AM
Unknown Object (File)
Sun, Apr 20, 2:02 AM
Unknown Object (File)
Thu, Apr 17, 4:16 PM
Unknown Object (File)
Thu, Apr 17, 4:00 PM
Unknown Object (File)
Thu, Apr 17, 2:44 AM
Unknown Object (File)
Wed, Apr 16, 11:34 PM
Unknown Object (File)
Wed, Apr 16, 2:02 PM
Unknown Object (File)
Wed, Apr 2, 4:31 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types
Summary

Types describing APNs responses, taken from Apple docs Handling notification responses from APNs.

Depends on D12612

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jun 28 2024, 5:29 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 5:30 AM
kamil added a child revision: D12614: [Tunnelbroker] implement sending APNs notif.Jun 28 2024, 5:37 AM
Harbormaster completed remote builds in B29992: Diff 41791.Jun 28 2024, 5:46 AM
kamil published this revision for review.Jun 28 2024, 6:31 AM
bartek accepted this revision.Jul 1 2024, 2:19 AM
bartek added inline comments.
services/tunnelbroker/src/notifs/apns/response.rs
4–6 ↗(On Diff #41791)

Should we add a link to Apple docs here? The one mentioned in the diff description

This revision is now accepted and ready to land.Jul 1 2024, 2:19 AM
kamil updated this revision to Diff 41883.Jul 2 2024, 5:58 AM

add link

Harbormaster completed remote builds in B30052: Diff 41883.Jul 2 2024, 6:15 AM
Closed by commit rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types (authored by kamil). · Explain WhyJul 2 2024, 8:35 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd669bb766e26: [Tunnelbroker] implement APNs response types.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
apns/
1 line
116 lines

Diff 41894

View Options

services/tunnelbroker/src/notifs/apns/mod.rs

// @flow // @flow
import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js';
import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js'; import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js'; import { defaultCalendarFilters } from 'lib/types/filter-types.js';
import type { import type {
WebInitialKeyserverInfo, WebInitialKeyserverInfo,
WebInitialReduxStateResponse, ClientWebInitialReduxStateResponse,
} from 'lib/types/redux-types.js'; } from 'lib/types/redux-types.js';
import { useKeyserverCall } from 'lib/utils/keyserver-call.js'; import { useKeyserverCall } from 'lib/utils/keyserver-call.js';
import type { URLInfo } from 'lib/utils/url-utils.js'; import type { URLInfo } from 'lib/utils/url-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import type { import type {
ExcludedData, ExcludedData,
InitialReduxState, InitialReduxState,
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines for (const keyserverID of allKeyserverIDs) {
requests[keyserverID] = { requests[keyserverID] = {
urlInfo: rest, urlInfo: rest,
excludedData: keyserverExcludedData, excludedData: keyserverExcludedData,
clientUpdatesCurrentAsOf, clientUpdatesCurrentAsOf,
}; };
} }
} }
const responses: { +[string]: WebInitialReduxStateResponse } = const responses: { +[string]: ClientWebInitialReduxStateResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'get_initial_redux_state', 'get_initial_redux_state',
requests, requests,
getInitialReduxStateCallSingleKeyserverEndpointOptions, getInitialReduxStateCallSingleKeyserverEndpointOptions,
); );
const { const {
currentUserInfo, currentUserInfo,
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/notifs/apns/response.rs

// @flow // @flow
import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js';
import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js'; import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js'; import { defaultCalendarFilters } from 'lib/types/filter-types.js';
import type { import type {
WebInitialKeyserverInfo, WebInitialKeyserverInfo,
WebInitialReduxStateResponse, ClientWebInitialReduxStateResponse,
} from 'lib/types/redux-types.js'; } from 'lib/types/redux-types.js';
import { useKeyserverCall } from 'lib/utils/keyserver-call.js'; import { useKeyserverCall } from 'lib/utils/keyserver-call.js';
import type { URLInfo } from 'lib/utils/url-utils.js'; import type { URLInfo } from 'lib/utils/url-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import type { import type {
ExcludedData, ExcludedData,
InitialReduxState, InitialReduxState,
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines for (const keyserverID of allKeyserverIDs) {
requests[keyserverID] = { requests[keyserverID] = {
urlInfo: rest, urlInfo: rest,
excludedData: keyserverExcludedData, excludedData: keyserverExcludedData,
clientUpdatesCurrentAsOf, clientUpdatesCurrentAsOf,
}; };
} }
} }
const responses: { +[string]: WebInitialReduxStateResponse } = const responses: { +[string]: ClientWebInitialReduxStateResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'get_initial_redux_state', 'get_initial_redux_state',
requests, requests,
getInitialReduxStateCallSingleKeyserverEndpointOptions, getInitialReduxStateCallSingleKeyserverEndpointOptions,
); );
const { const {
currentUserInfo, currentUserInfo,
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines