Page MenuHomePhabricator
Differential D12827

[lib] Reduce duplication in message-types.js
ClosedPublic
Actions

Authored by ashoat on Jul 20 2024, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 21 2025, 6:32 AM
Unknown Object (File)
Feb 16 2025, 5:59 PM
Unknown Object (File)
Feb 16 2025, 5:59 PM
Unknown Object (File)
Jan 22 2025, 12:19 AM
Unknown Object (File)
Jan 10 2025, 9:20 AM
View All 55 Files
Subscribers
None

Details

Reviewers
tomek
kamil
marcin
Commits
rCOMMfa1d5228f1a2: [lib] Reduce duplication in message-types.js
Summary

Noticed the same two properties being redefined in a bunch of types. Figured it made sense to factor it out.

Depends on D12826

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
types/
28 lines

Diff 42627

View Options

lib/types/message-types.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines