Page MenuHomePhabricator

[lib] Make sure thick threads starts out with startReached
ClosedPublic

Authored by ashoat on Jul 20 2024, 9:43 PM.
Tags
None
Referenced Files
F3524440: D12828.id42628.diff
Mon, Dec 23, 12:40 PM
F3524439: D12828.id42594.diff
Mon, Dec 23, 12:40 PM
F3524422: D12828.id.diff
Mon, Dec 23, 12:39 PM
F3524419: D12828.diff
Mon, Dec 23, 12:39 PM
Unknown Object (File)
Thu, Nov 28, 5:58 PM
Unknown Object (File)
Nov 15 2024, 5:00 AM
Unknown Object (File)
Nov 15 2024, 2:05 AM
Unknown Object (File)
Nov 8 2024, 6:11 AM
Subscribers
None

Details

Summary

In order to make sure that startReached starts out as true when a thread is created, we set truncationStatus to "exhaustive".

I thought about always using exhaustive, but this conflicts with our plans in the Limit number of displayed DMs project, where we'll want startReached to be false if there are messages in SQLite that are not represented in Redux.

Depends on D12827

Test Plan

I followed the test plan described in this Linear comment. Before this diff, the spinner was visible in the newly-created thick thread. After this diff, it was no longer visible

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable