Page MenuHomePhabricator
Differential D13379

[keyserver] return default avatar to old clients when avatar type is "farcaster"
ClosedPublic
Actions

Authored by varun on Sep 18 2024, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 4:56 PM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 2:32 PM
Unknown Object (File)
Sat, Oct 19, 2:31 PM
Unknown Object (File)
Tue, Oct 15, 1:28 AM
Unknown Object (File)
Fri, Oct 11, 9:05 AM
Unknown Object (File)
Oct 6 2024, 5:49 AM
View All 27 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMca9f26b446f1: [keyserver] return default avatar to old clients when avatar type is "farcaster"
Summary

when a viewer tries to fetch their own avatar or another user's avatar on an old client, we should return the default avatar. older clients will not be able to handle farcaster avatars

Depends on D13378

Test Plan

default avatar displays on older native app

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 18 2024, 6:14 AM
varun added a child revision: D13380: [web] make it possible to select farcaster avatar on web.Sep 18 2024, 6:19 AM
Harbormaster completed remote builds in B31688: Diff 44298.Sep 18 2024, 6:31 AM
varun requested review of this revision.Sep 18 2024, 6:31 AM
ashoat added inline comments.Sep 18 2024, 7:53 AM
keyserver/src/fetchers/user-fetchers.js
184

When will this get moved to NEXT_CODE_VERSION?

ashoat accepted this revision.Sep 18 2024, 7:53 AM
This revision is now accepted and ready to land.Sep 18 2024, 7:53 AM
varun added inline comments.Sep 25 2024, 5:45 AM
keyserver/src/fetchers/user-fetchers.js
184

https://linear.app/comm/issue/ENG-9395/enable-farcaster-avatars-for-next-code-version

we'll do it after we have native releases with farcaster avatar support

ashoat added inline comments.Sep 25 2024, 5:53 AM
keyserver/src/fetchers/user-fetchers.js
184

This doesn't match the normal release process – see comments there. Are you sure you don't want to update this to NEXT_CODE_VERSION now?

Closed by commit rCOMMca9f26b446f1: [keyserver] return default avatar to old clients when avatar type is "farcaster" (authored by varun). · Explain WhySep 25 2024, 7:24 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMca9f26b446f1: [keyserver] return default avatar to old clients when avatar type is "farcaster".

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
22 lines

Diff 44298

View Options

keyserver/src/fetchers/user-fetchers.js

Loading...