Page MenuHomePhabricator
Differential D13602

[tunnelbroker] Implement AMQP Channel hash-modulo-N pool
Changes PlannedPublic
Actions

Authored by bartek on Oct 3 2024, 1:35 PM.
Tags
None
Referenced Files
F3513158: D13602.id44882.diff
Sat, Dec 21, 10:57 PM
F3513136: D13602.diff
Sat, Dec 21, 10:49 PM
Unknown Object (File)
Wed, Dec 18, 12:08 PM
Unknown Object (File)
Wed, Dec 18, 12:08 PM
Unknown Object (File)
Wed, Dec 18, 12:07 PM
Unknown Object (File)
Nov 10 2024, 8:29 AM
Unknown Object (File)
Nov 8 2024, 10:37 PM
Unknown Object (File)
Nov 8 2024, 1:49 PM
View All 29 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Summary

A deterministic distribution of channel number based on name/net address/device ID, basically anything that is hashable

Depends on D13601

Test Plan

Confirmed that the same device ID will always receive the same channel index

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Oct 3 2024, 1:35 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 1:35 PM
bartek added a child revision: D13603: [tunnelbroker] Implement AMQP reconnect on channel access.Oct 3 2024, 1:36 PM
Harbormaster completed remote builds in B32053: Diff 44882.Oct 3 2024, 2:07 PM
bartek published this revision for review.Oct 4 2024, 3:46 AM
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
bartek planned changes to this revision.Oct 4 2024, 5:33 AM

It turns out that multiple devices using the same channel cause conflicts, for now I'll resign from channel pool and simply create a new channel on access.
Old channels will be dropped automatically (they implement Drop)

bartek removed a child revision: D13603: [tunnelbroker] Implement AMQP reconnect on channel access.Oct 4 2024, 8:20 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
21 lines

Diff 44882

View Options

services/tunnelbroker/src/amqp.rs

Loading...