[tunnelbroker] Implement AMQP Channel hash-modulo-N pool
AbandonedPublic
Actions

Authored by bartek on Oct 3 2024, 8:35 PM.

Details

Reviewers

kamil
varun
will

Summary

A deterministic distribution of channel number based on name/net address/device ID, basically anything that is hashable

Depends on D13601

Test Plan

Confirmed that the same device ID will always receive the same channel index

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 3 2024, 8:35 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 8:35 PM

bartek added a child revision: D13603: [tunnelbroker] Implement AMQP reconnect on channel access.Oct 3 2024, 8:36 PM

Harbormaster completed remote builds in B32053: Diff 44882.Oct 3 2024, 9:07 PM

bartek published this revision for review.Oct 4 2024, 10:46 AM

bartek edited the summary of this revision. (Show Details)

bartek edited the test plan for this revision. (Show Details)

It turns out that multiple devices using the same channel cause conflicts, for now I'll resign from channel pool and simply create a new channel on access.
Old channels will be dropped automatically (they implement Drop)

bartek removed a child revision: D13603: [tunnelbroker] Implement AMQP reconnect on channel access.Oct 4 2024, 3:20 PM

We used a different approach for the above reason

bartek mentioned this in D13610: [tunnelbroker] Recreate closed channels in pool.Sep 19 2025, 4:03 PM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

amqp.rs

21 lines

Diff 44882

View Options

services/tunnelbroker/src/amqp.rs

[tunnelbroker] Implement AMQP Channel hash-modulo-N poolAbandonedPublicActions