[keyserver/lib] Change frame image from hello world to channel image
ClosedPublic
Actions

Authored by will on Nov 20 2024, 8:45 PM.

Details

Reviewers

varun
ashoat

Commits

rCOMM9135d719942e: [keyserver/lib] Change frame image from hello world to channel image

Summary

Currently the frame image is just the text "Hello world". As part of the first changes to the image, we're replacing the background of the image
with the farcaster channel's cover image if it exists. If it doesn't, we use the default channel image

Depends on D13971

Test Plan

Tested in the warpcast frame validator. Confirmed that the frame image displayed was just the channel cover image

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Nov 20 2024, 8:45 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 20 2024, 8:45 PM

will added inline comments.Nov 20 2024, 8:46 PM

keyserver/src/frog/frog.js
43 ↗	(On Diff #45915)	This is a placeholder. I plan to include the default cover image in `keyserver/images`, statically serve it through the Frog Hono server, and use its URL here in future diffs

Harbormaster completed remote builds in B32741: Diff 45915.Nov 20 2024, 9:03 PM

will requested review of this revision.Nov 20 2024, 9:03 PM

ashoat accepted this revision.Nov 21 2024, 4:02 PM

ashoat added inline comments.

keyserver/flow-typed/npm/frog_v0.18.x.js
41 ↗	(On Diff #45915)	Can it actually return either `Promise<FrogResponse>` or `FrogResponse`?
keyserver/src/frog/frog.js
33–39 ↗	(On Diff #45915)	This seems more readable

This revision is now accepted and ready to land.Nov 21 2024, 4:02 PM

will added a child revision: D13998: [keyserver] Add Thread Invitation box to the frame.Thu, Nov 21, 11:32 PM

feedback

Harbormaster completed remote builds in B32956: Diff 46250.Fri, Dec 6, 7:37 PM

ashoat added inline comments.Sun, Dec 8, 8:07 PM

keyserver/flow-typed/npm/frog_v0.18.x.js
41 ↗	(On Diff #45915)	This feedback appears to have been ignored

will added inline comments.Mon, Dec 9, 6:12 AM

keyserver/flow-typed/npm/frog_v0.18.x.js
41 ↗	(On Diff #45915)	Frog specifies that you can have the callback be asynchronous: `A frame handler can also be asynchronous (ie. async (c) => { ... }).` You can do so by adding `async` in front of the callback function: `frogApp.frame('/', c => { ...` `frogApp.frame('/', async c => { ...` From my understanding of flow, we only need to include the return type as `Promise<>` to specify the callback as async

will added inline comments.Mon, Dec 9, 6:14 AM

keyserver/flow-typed/npm/frog_v0.18.x.js
41 ↗	(On Diff #45915)	Ah. Already wrote a comment but didn't hit submit

ashoat added inline comments.Mon, Dec 9, 8:25 AM

keyserver/flow-typed/npm/frog_v0.18.x.js
41 ↗	(On Diff #45915)	The first example is not returning `Promise<FrogResponse>`, it's returning `FrogResponse` Seems like you should update the signature to be returning `Promise<FrogResponse> \| FrogResponse`